/matplotlib

Use `figure.stale` instead of internal member in macosx #6283

Merged
merged 2 commits into from Apr 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
GUI/osx
Projects
None yet
Milestone
  v2.0.0
5 participants
@mdboom @jenshnielsen @tacaswell @dstansby @QuLogic
@mdboom
Owner

mdboom commented Apr 8, 2016

Fix #6237.

mdboom added some commits Apr 8, 2016

@mdboom mdboom Use figure.stale instead of canvas._needs_draw c4614b4
@mdboom mdboom Don't explicitly unstale the figure

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
ee192c3

mdboom added this to the 2.0 (style change major release) milestone Apr 8, 2016

mdboom added the needs_review label Apr 8, 2016

@jenshnielsen
Owner

jenshnielsen commented Apr 8, 2016

👍 it also fixes an issue that I have been seeing (but forgot to report) with the image_slices_viewer.py example
@jenshnielsen
Owner

jenshnielsen commented Apr 9, 2016

I can also confirm that it fixes #6237 for me
@mdboom
Owner

mdboom commented Apr 11, 2016

I think this is good-to-go. The appveyor test is obviously a false negative.

@jenshnielsen jenshnielsen merged commit 997029b into matplotlib:master Apr 11, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Apr 11, 2016

@jenshnielsen jenshnielsen added a commit that referenced this pull request Apr 11, 2016

@jenshnielsen @jenshnielsen jenshnielsen + jenshnielsen Merge pull request #6283 from mdboom/macagg-events 
Use `figure.stale` instead of internal member in macosx
 bdc3b25
@jenshnielsen
Owner

jenshnielsen commented Apr 11, 2016

backported to 2.x as bdc3b25

QuLogic added the GUI/osx label May 28, 2017

@dstansby
Contributor

dstansby commented on lib/matplotlib/backends/backend_macosx.py in c4614b4 Jun 29, 2017

Was removing this line intentional? It seems to have caused #8814, and changing this line to

        self.figure.stale = True

fixes the problem.
Owner

tacaswell replied Jun 29, 2017

I think this is exposing a bug that something else is not properly marking the figure as stale when it changes it. In principle, if nothing has changed draw_idle can be a no-op
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment