Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Only render markers on a line when markersize > 0 #6314
Conversation
mdboom
added the
needs_review
label
Apr 18, 2016
mdboom
added this to the
1.5.2 (Critical bug fix release)
milestone
Apr 18, 2016
|
|
|
Is it possible to add a test to prevent regressions? |
|
So a test for whether indeed nothing is rendered? A problem here is that the #6294 bug occurs with the Adobe Acrobat renderer. During testing, the pdf for comparison is converted to png by Ghostscript. So the faulty behavior would not occur in this setup. Updating the testing to use Acrobat seems like a rather big change and would not work on all systems. |
|
Oh, I didn't realize the effect is only seen with Adobe's renderer. |
|
I'm not 100% sure it's only Acrobat, but I tested with Ghostscript 9.19 and those dots do not show up there. |
tacaswell
merged commit f0b7026
into matplotlib:master
Apr 20, 2016
tacaswell
removed the
needs_review
label
Apr 20, 2016
tacaswell
added a commit
that referenced
this pull request
Apr 20, 2016
|
|
tacaswell |
38d9638
|
|
Thanks! Backported to v1.5.x as 38d9638 |
henningpohl
deleted the
henningpohl:patch-1 branch
Apr 20, 2016
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
|
|
tacaswell |
2f383e5
|
henningpohl commentedApr 18, 2016
Fixes issue #6294 by only rendering markers when their size is larger than zero.