Add default scatter marker option to rcParams #6328

Merged
merged 3 commits into from Apr 29, 2016

Conversation

Projects
None yet
4 participants
Contributor

bcongdon commented Apr 24, 2016

Addresses #6272.

Removes hard-coded 'o' as the default marker from within the scatter definition. Adds the 'scatter.marker' option in rcParams, which is then loaded when scatter is called.

This is my first contribution, so I apologize in advance if I've violated any best practices.

@bcongdon bcongdon Add 'scatter.marker' option to rcParams
2e188bf

mdboom added the needs_review label Apr 24, 2016

Contributor

bcongdon commented Apr 25, 2016

The AppVeyor build looks like it failed because it took too long to download freetype.

efiring referenced this pull request Apr 26, 2016

Merged

Color cycle handling #6291

Owner

tacaswell commented Apr 26, 2016

Can you also add this key to matplotlibrc.template and the classic style sheet?

Contributor

bcongdon commented Apr 26, 2016

Alright, done.

@tacaswell tacaswell commented on an outdated diff Apr 26, 2016

matplotlibrc.template
@@ -461,6 +461,9 @@ backend : $TEMPLATE_BACKEND
# If Numpy 1.11 or later is
# installed, may also be `auto`
+### SCATTER PLOTS
+#scatter.marker # The default marker type for scatter plots.
@tacaswell

tacaswell Apr 26, 2016

Owner

This needs : o

@bcongdon bcongdon Add 'scatter.marker' to matplotlibrc.template and classic style sheet
f0dcc36
Contributor

bcongdon commented Apr 26, 2016

Whoops, my mistake. Fixed.

Owner

tacaswell commented Apr 28, 2016

One more house keeping thing, can you add a note in https://github.com/matplotlib/matplotlib/blob/master/doc/users/whats_new/rcparams.rst documenting this feature?

@bcongdon bcongdon Add 'scatter.marker' to whats_new/rcparams.rst
e9a96e8
Contributor

bcongdon commented Apr 28, 2016

Sure, added that to the docs.

@tacaswell tacaswell merged commit 585d128 into matplotlib:master Apr 29, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.668%
Details

tacaswell removed the needs_review label Apr 29, 2016

@tacaswell tacaswell added a commit that referenced this pull request Apr 29, 2016

@tacaswell tacaswell Merge pull request #6328 from benjamincongdon/ft-scatter-marker-rc
Add default scatter marker option to rcParams
ad81e3f
Owner

tacaswell commented Apr 29, 2016

Thanks! backported to v2.x as ad81e3f

I think this is your first contribution to mpl. Congratulations, hopefully we will see you again 😄

QuLogic added the Rcparams label May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment