/matplotlib

BLD: make minimum cycler version 0.10.0 #6340

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
5 participants
@tacaswell @jenshnielsen @WeatherGod @mdboom @QuLogic
@tacaswell
Owner

tacaswell commented Apr 27, 2016

closes #6325

tacaswell added the needs_review label Apr 27, 2016

tacaswell added this to the 2.1 (next point release) milestone Apr 27, 2016

@tacaswell
Owner

tacaswell commented Apr 27, 2016

attn @WeatherGod

I think we did not backport those changes to 2.x so I do not think this needs to be backported either.
@jenshnielsen
Owner

jenshnielsen commented Apr 27, 2016

In that case I think 2.x should run the tests with cycler 0.9 on Travis as 1.5.x does
@WeatherGod
Member

WeatherGod commented Apr 27, 2016

Also need to update setupext.py
@tacaswell
Owner

tacaswell commented Apr 27, 2016

@WeatherGod update what else in setupext.py?
@WeatherGod
Member

WeatherGod commented Apr 27, 2016

Sorry, let me clarify... in my PR, I updated get_install_requires() so that it returned "cycler>=0.9". I don't know why the diff you have does not reflect that.
@tacaswell
Owner

tacaswell commented Apr 27, 2016

I could not find anything in the code that did any version checking on cycler last night (which confused me). Maybe we lost it in a bad merge?
@WeatherGod
Member

WeatherGod commented Apr 27, 2016

The faulty PR is #6275. It was backported to 2.x.
@tacaswell
Owner

tacaswell commented Apr 27, 2016

🐑 I forgot to update my local master before forking this branch, stand by.
@tacaswell tacaswell BLD: make minimum cycler version 0.10.0 
closes #6325

All checks have passed

2 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
e92eb88

@WeatherGod WeatherGod merged commit 40150b3 into matplotlib:master Apr 27, 2016
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Apr 27, 2016

tacaswell deleted the tacaswell:bld_update_cycler_dep branch Apr 27, 2016

@WeatherGod WeatherGod added a commit that referenced this pull request Apr 27, 2016

@WeatherGod WeatherGod Merge pull request #6340 from tacaswell/bld_update_cycler_dep 
BLD: make minimum cycler version 0.10.0
 9f83d53
@WeatherGod
Member

WeatherGod commented Apr 27, 2016

backported as 9f83d53

@QuLogic QuLogic modified the milestone: 2.0 (style change major release), 2.1 (next point release) Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment