Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update events handling documentation to work with Python 3. #6354
Conversation
mdboom
added the
needs_review
label
Apr 30, 2016
|
|
tacaswell
added this to the
2.1 (next point release)
milestone
Apr 30, 2016
tacaswell
closed this
May 1, 2016
tacaswell
reopened this
May 1, 2016
tacaswell
added needs_review and removed needs_review
labels
May 1, 2016
|
Is the coverage failure messed up? It's talking about changes in coverage that didn't have anything to do with what I changed. |
tacaswell
merged commit 3b8c094
into matplotlib:master
May 1, 2016
tacaswell
removed the
needs_review
label
May 1, 2016
tacaswell
added a commit
that referenced
this pull request
May 1, 2016
|
|
tacaswell |
520d1a1
|
|
backported to v1.5.1-doc as 520d1a1 |
|
I closed and re-opened to re-trigger the builds. I do not know what it's base line is, but it might be looking at the first time it ran this PR vs the second time it ran this PR against a different master. |
QuLogic
modified the milestone: 1.5.2 (Critical bug fix release), 2.1 (next point release)
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pganssle commentedApr 30, 2016
•
edited
Event handling documentation has a lot of Python 2-style print statements, so I have updated them here. I ran the code snippets in Python 3 and they all work. The only difference is that for the Python 3 version, the outputs look like this:
And for Python 2 they look like this now:
They used to not have parens around the outputs, but they do now because of the parens required to make it polyglot code. The old behavior can return if you prepend
from __future__ import print_function, but I don't really think that's necessary.