/matplotlib

Sort default labels numerically in Qt editor. #6366

Merged
merged 1 commit into from May 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
GUI/Qt
Projects
None yet
Milestone
  v2.0.0
4 participants
@anntzer @tacaswell @mdboom @QuLogic
@anntzer
Contributor

anntzer commented May 5, 2016

See #6315.
@anntzer anntzer Sort default labels numerically in Qt editor.

Some checks were not successful

1 errored, 1 failing, and 1 pending checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
coverage/coveralls — Coverage pending from Coveralls.io
Details
ad4830c

mdboom added the needs_review label May 5, 2016

tacaswell added this to the 2.1 (next point release) milestone May 5, 2016

@tacaswell
Owner

tacaswell commented May 5, 2016

I still think padding the default label with 0 would be simpler, but this is much less disruptive (no API change) and works to (unreasonably) large numbers of lines/images. This is much better than what I suggested.

👍

Can you add a note to the whats new being accumulated in #6361?

merging despite failing tests as a) the test failures are due to a blue -> black default change and b) this code path is not tested.

@tacaswell tacaswell merged commit 0c07515 into matplotlib:master May 5, 2016
0 of 3 checks passed

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage pending from Coveralls.io
Details

tacaswell removed the needs_review label May 5, 2016

anntzer deleted the anntzer:sort-line-and-image-labels-numerically branch May 5, 2016

@anntzer
Contributor

anntzer commented May 5, 2016

How should I do this? Should I PR on your repo?
@tacaswell
Owner

tacaswell commented May 5, 2016

That would work, or just put in a new PR with more commits on top of that
branch (and I will close my PR).

On Thu, May 5, 2016 at 12:30 PM Antony Lee notifications@github.com wrote:

How should I do this? Should I PR on your repo?

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#6366 (comment)

QuLogic added the GUI/Qt label May 5, 2016

This was referenced Jul 10, 2016

Merged
Closed
Merged

@QuLogic QuLogic modified the milestone: 2.0 (style change major release), 2.1 (next point release) Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment