/matplotlib

Update demo_floating_axes.py with comments #6369

Merged
merged 2 commits into from May 6, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@dstansby @tacaswell @mdboom
@dstansby
Contributor

dstansby commented May 5, 2016

A couple of comments I think are useful when looking at the demo
@dstansby dstansby Update demo_floating_axes.py

Some checks were not successful

1 errored, 1 failing, and 1 pending checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
coverage/coveralls — Coverage pending from Coveralls.io
Details
eeadf7b

mdboom added the needs_review label May 5, 2016

@tacaswell tacaswell and 1 other commented on an outdated diff May 5, 2016

View full outdated diff
examples/axisartist/demo_floating_axes.py
@@ -84,7 +84,9 @@ def setup_axes3(fig, rect):
grid_locator2 = MaxNLocator(3)
+ # Set theta limits in degrees
@tacaswell

tacaswell May 5, 2016

Owner

To be slightly bikesheddy, does this read as the local assignment sets the limits, rather than these will be the limits that are passed in via the extremes kwargs to GridHelperCurveLinear below.

I may have been doing too much pytest work recently and am looking for magic everywhere...

@dstansby

dstansby May 5, 2016

Contributor

Sounds fair to me! I've changed the wording to 'specify' which should be better
@dstansby dstansby Update demo_floating_axes.py

Some checks were not successful

1 errored, 1 failing, and 1 pending checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
coverage/coveralls — Coverage pending from Coveralls.io
Details
9e07833

tacaswell added this to the 2.1 (next point release) milestone May 5, 2016

tacaswell added the Documentation label May 5, 2016

@tacaswell
Owner

tacaswell commented May 5, 2016

👍 I will let the tests run (even though I am pretty sure they are going to fail for un-related reasons).

@tacaswell tacaswell merged commit 76a884c into matplotlib:master May 6, 2016
0 of 3 checks passed

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage pending from Coveralls.io
Details

tacaswell removed the needs_review label May 6, 2016

dstansby deleted the unknown repository branch Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment