Fix canonical name for "None" linestyle. #6381

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
5 participants
Contributor

anntzer commented May 8, 2016

The canonical "empty" linestyle is "None", not "none". The previous
implementation would raise an error after running

plot([1, 2], ls="none")

and opening the figure options editor.

@anntzer anntzer Fix canonical name for "None" linestyle.
The canonical "empty" linestyle is "None", not "none".  The previous
implementation would raise an error after running

    plot([1, 2], ls="none")

and opening the figure options editor.
0a6e84d

mdboom added the needs_review label May 8, 2016

Member

WeatherGod commented May 8, 2016

Really? I always thought that we promoted the lowercase form to reduce
confusion with the python None.
On May 7, 2016 8:17 PM, "Antony Lee" notifications@github.com wrote:

The canonical "empty" linestyle is "None", not "none". The previous
implementation would raise an error after running

plot([1, 2], ls="none")

and opening the figure options editor.

You can view, comment on, or merge this pull request online at:

#6381
Commit Summary

  • Fix canonical name for "None" linestyle.

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#6381

Contributor

anntzer commented May 8, 2016

I agree that "none" would have been preferable, but both on 1.5.1 and master:

In [1]: plt.plot([1, 2], ls="none")[0].get_linestyle()
Out[1]: 'None'

QuLogic added the GUI/Qt label May 8, 2016

tacaswell added this to the 2.1 (next point release) milestone May 8, 2016

Contributor

anntzer commented Jul 8, 2016

Bumping.
Hopefully this can make it to 2.0? Again it should be a straight, non-controversial bug fix.
We can always switch the "canonical" none-linestyle as lowercase "none" later (which I'd prefer... modulo back-compatibility issues); we'd just need to revert this PR if that happens.

Owner

tacaswell commented Jul 9, 2016

The failure on building the docs seems to be persistent, but not showing up anywhere else.

@tacaswell tacaswell merged commit 7206ae7 into matplotlib:master Jul 9, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 69.641%
Details

tacaswell removed the needs_review label Jul 9, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jul 9, 2016

@tacaswell tacaswell Merge pull request #6381 from anntzer/figure-options-canonical-none-l…
…inestyle

Fix canonical name for "None" linestyle in qtconfig gui
f7aa7b3
Owner

tacaswell commented Jul 9, 2016

backported to v2.x as f7aa7b3

anntzer deleted the anntzer:figure-options-canonical-none-linestyle branch Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment