Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Minor improvements concerning #6353 and #6357 #6386
Conversation
khyox
added some commits
May 6, 2016
mdboom
added the
needs_review
label
May 8, 2016
tacaswell
closed this
May 8, 2016
tacaswell
reopened this
May 8, 2016
tacaswell
added needs_review and removed needs_review
labels
May 8, 2016
|
power-cycled to re-run CI against current master (which has had some un-related fixes applied). |
tacaswell
and 1 other
commented on an outdated diff
May 8, 2016
| @@ -5801,9 +5801,11 @@ def hist(self, x, bins=None, range=None, normed=False, weights=None, | ||
| normed : boolean, optional | ||
| If `True`, the first element of the return tuple will | ||
| be the counts normalized to form a probability density, i.e., | ||
| - ``n/(len(x)`dbin)``, i.e., the integral of the histogram will sum | ||
| - to 1. If *stacked* is also *True*, the sum of the histograms is | ||
| - normalized to 1. | ||
| + the integral of the histogram will sum to 1. So, the normalized |
tacaswell
Owner
|
|
The remaining issue on Travis is a whitespace issue from pep8 /home/travis/build/matplotlib/matplotlib/lib/matplotlib/axes/_axes.py:5807:73: W291 trailing whitespace |
|
Many thanks @jenshnielsen! It should be right now. Let us see the result of the tests... |
tacaswell
merged commit aeb6112
into matplotlib:master
May 9, 2016
|
Thanks! |
tacaswell
removed the
needs_review
label
May 9, 2016
|
@tacaswell, @jenshnielsen: Sorry, I know I made this a bit painful! |
|
Thank you for being patient with us. |
khyox commentedMay 8, 2016
Related with #6353 and #6357, this commit corrects ylabel string in histogram_demo_features.py example but also tries to improve the documentation of hist in pyplot to clarify which one of the two common ways to normalize the counts is available through this option and which is not, in order to avoid future misunderstandings.