/matplotlib

more explicit message for missing image #6402

Merged
merged 1 commit into from May 12, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@prinsherbert @mdboom @tacaswell @QuLogic
@prinsherbert

prinsherbert commented May 11, 2016

Pointing out what exactly the problem is, is a nice feature of raised stuff; we all hate a file not found error without the exact file being specified.

If someone simple copies something from lib/matplotlib/tests and alters it for his or her need, he will be pointed to likely missing comparison files without the need to know about the exact workings of the image_comparison decorator.
Herbert Kruitbosch more explicit message for missing image

Some checks were not successful

1 errored and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
coverage/coveralls — Coverage remained the same at 69.631%
Details
9d49793

mdboom added the needs_review label May 11, 2016

@tacaswell tacaswell merged commit c16d8f5 into matplotlib:master May 12, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 69.631%
Details

tacaswell removed the needs_review label May 12, 2016

QuLogic added the Testing label May 12, 2016

QuLogic added this to the 2.1 (next point release) milestone May 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment