removing unused DialogLineprops from gtk3 #6415

Merged
merged 1 commit into from May 13, 2016

Conversation

Projects
None yet
5 participants
Member

fariza commented May 12, 2016

The class DialogLineprops was copied from gtk2 to Gtk3 but it doesn't work.
Also it is not used anywhere.

Federico Ariza removing unused DialogLineprops from gtk3
1a2630f

mdboom added the needs_review label May 12, 2016

Owner

tacaswell commented May 12, 2016

should this be backported to 2,x?

Member

fariza commented May 12, 2016

It doesn't fix anything, just removes dead code. It depends on the policy/criteria for back-porting stuff

@tacaswell tacaswell merged commit a1dbdc1 into matplotlib:master May 13, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.749%
Details

tacaswell removed the needs_review label May 13, 2016

@tacaswell tacaswell added a commit that referenced this pull request May 13, 2016

@tacaswell tacaswell Merge pull request #6415 from fariza/remove-gtk-linepropsdialog
CLN: removing unused DialogLineprops from gtk3
25bdedd
Owner

tacaswell commented May 13, 2016

backported to v2.x as 25bdedd

Why ship code we know is broken and unused?

fariza deleted the fariza:remove-gtk-linepropsdialog branch May 17, 2016

Contributor

OceanWolf commented Jun 21, 2016

Just rebasing MEP27 and noticed this had gone... as it exists as a Qt tool, I had thought about rewriting this as a generic tool for all backends, i.e. replacing the native widgets with matplotlib versions of the widgets, making it a backend independant tool like subplots tool becomes in MEP27.

Not really super keen on spending time doing that, but otherwise we would either have to write code that only adds that tool for Qt, or loose it together, which may well see lots of complaints...

Owner

tacaswell commented Jun 21, 2016

Losing the Qt version is a non-starter

Contributor

OceanWolf commented Jun 21, 2016

I thought so ;)... just that with the new toolbar, we have a default list of tools which get applied independent of backend. Without a nasty hack, implement lineprops as a backend independent tool would probably look the nicest, no nasty hacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment