Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
removing unused DialogLineprops from gtk3 #6415
Conversation
mdboom
added the
needs_review
label
May 12, 2016
|
should this be backported to 2,x? |
|
It doesn't fix anything, just removes dead code. It depends on the policy/criteria for back-porting stuff |
tacaswell
merged commit a1dbdc1
into matplotlib:master
May 13, 2016
tacaswell
removed the
needs_review
label
May 13, 2016
tacaswell
added a commit
that referenced
this pull request
May 13, 2016
|
|
tacaswell |
25bdedd
|
|
backported to v2.x as 25bdedd Why ship code we know is broken and unused? |
QuLogic
added this to the
2.0 (style change major release)
milestone
May 13, 2016
fariza
deleted the
fariza:remove-gtk-linepropsdialog branch
May 17, 2016
|
Just rebasing MEP27 and noticed this had gone... as it exists as a Qt tool, I had thought about rewriting this as a generic tool for all backends, i.e. replacing the native widgets with matplotlib versions of the widgets, making it a backend independant tool like subplots tool becomes in MEP27. Not really super keen on spending time doing that, but otherwise we would either have to write code that only adds that tool for Qt, or loose it together, which may well see lots of complaints... |
|
Losing the Qt version is a non-starter |
|
I thought so ;)... just that with the new toolbar, we have a default list of tools which get applied independent of backend. Without a nasty hack, implement lineprops as a backend independent tool would probably look the nicest, no nasty hacking. |
fariza commentedMay 12, 2016
The class DialogLineprops was copied from gtk2 to Gtk3 but it doesn't work.
Also it is not used anywhere.