Showraise gtk gtk3 #6417

Merged
merged 3 commits into from May 17, 2016

Conversation

Projects
None yet
5 participants
Member

fariza commented May 13, 2016 edited

Following #6384 in response to #6378

The gtk trick is a little bit more obscure because not all methods work in all versions of pygtk, I hope this one will work for everyone

Federico Ariza added some commits May 13, 2016

Federico Ariza raise in gtk3 bd77200
Federico Ariza raise window gtk
96097ad

mdboom added the needs_review label May 13, 2016

Member

fariza commented May 13, 2016

@efiring I did a separate PR, is this OK?

tacaswell added this to the 2.1 (next point release) milestone May 13, 2016

Owner

efiring commented May 13, 2016

Yes, a separate PR is fine. Thanks for doing this.

@jenshnielsen jenshnielsen commented on an outdated diff May 14, 2016

lib/matplotlib/backends/backend_gtk.py
@@ -613,6 +613,8 @@ def destroy(self, *args):
def show(self):
# show the figure window
self.window.show()
+ self.window.set_keep_above(True)
@jenshnielsen

jenshnielsen May 14, 2016

Owner

It's probably useful to document with a comment that this is intended so that no one "optimises" it away

@fariza fariza comment for gkt way of doing raise
6f3e2a2
Owner

jenshnielsen commented May 17, 2016

Appveyor not relevant fixed by #6423

@jenshnielsen jenshnielsen merged commit 7d66623 into matplotlib:master May 17, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.4%) to 69.749%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label May 17, 2016

fariza deleted the fariza:showraise-gtk-gtk3 branch May 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment