TST: splitlines in rec2txt test

[tacaswell]

On windows the output has '\r\n' instead of '\n' for new
lines.

If this passes I plan to self-merge to un-break appveyor

[tacaswell]

attn @dopplershift I think this is an equivalent test .

[tacaswell]

@janschulz Can you help out with the windows issue here? I do not have a system to test on and debugging via appveyor seems maddeningly painful!

[dopplershift]

👍 from me.

[tacaswell]

In windows this seems to output one less space is some cases:

windows = ['       x   y   s    s2', '   1.000   2   foo  bing ']
truth =   ['       x   y   s   s2',  '   1.000   2   foo bing ']

[tacaswell]

Sorry, had order flipped, windows adds an extra space.

[tacaswell]

@dopplershift I think there was a bug in computing the width of the string columns which for some reason was behaving differently on windows/linux.

[janschulz]

I have a look... Looks like there are at least two problems:

The one where the link step can't find png.lib and the one where there is a space difference.

Re the png one: it seems that conda-forge recently added a libpng (and that one is installed), could be that there is a difference to the official one? https://github.com/conda-forge/libpng-feedstock/commits/master (cc: @ocefpaf)

[tacaswell]

I think I have the space issue fixed

[dopplershift]

I'm not convinced len() will do what we want if the data for a column is ['foo', 'bars']. Probably should change the test to have some differing string sizes and see what happens.

[tacaswell]

is that allowed in recarrays? The types look like fixed-width string, not variable width.

[dopplershift]

In [18]: a = np.array([(1, 'foo'), (2, 'bars')], dtype=np.dtype([('i', np.int32), ('s', np.str, 4)]))

In [19]: a
Out[19]:
array([(1, 'foo'), (2, 'bars')],
      dtype=[('i', '<i4'), ('s', '<U4')])

In [20]: len(a['s'][0])
Out[20]: 3

I couldn't find a numpy function to get that 4 from the <U4, which is what we really want.

[dopplershift]

But it turns out my original code was broken as well:

In [29]: a['s'][0].itemsize
Out[29]: 3

WTF?

[QuLogic]

Maybe you want a.dtype['s'].itemsize == 16 ( / 4 for Unicode == 4)?

[tacaswell]

len() is not the right thing. The best I can come up with is int(a.dtype['s'].str[2:])

[tacaswell]

And tests are passing, but it is dying as while trying to build the conda package

[tacaswell]

ok, this is now passing (except for a down-load error on one of the appveyor tests).

I had to turn off the conda package building which is less than great, but makes the test useful again for code review.

[cgohlke]

Is this going to be backported? matplotlib 1.5.2rc1 on Windows fails one test:

======================================================================
FAIL: test_csv2txt_basic (matplotlib.tests.test_mlab.rec2txt_testcase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "X:\Python35\lib\site-packages\matplotlib\tests\test_mlab.py", line 409, in test_csv2txt_basic
    assert_equal(mlab.rec2txt(a), truth)
AssertionError: '       x   y   s    s2\r\n   1.000   2   foo  bing \r\n   2.[16 chars]lah ' != '       x   y   s   s2\n   1.000   2   foo bing \n   2.000   3   bar blah '
-        x   y   s    s2
?                 -     -
+        x   y   s   s2
-    1.000   2   foo  bing
?                   -      -
+    1.000   2   foo bing
-    2.000   3   bar  blah ?                   -
+    2.000   3   bar blah

----------------------------------------------------------------------
Ran 5209 tests in 1399.371s

[tacaswell]

Yes, sorry this got lost in the appveyor related issues.

On Sun, May 22, 2016, 20:12 Christoph Gohlke notifications@github.com
wrote:

Is this going to be backported? matplotlib 1.5.2rc1 on Windows fails one
test:

FAIL: test_csv2txt_basic (matplotlib.tests.test_mlab.rec2txt_testcase)

Traceback (most recent call last):
File "X:\Python35\lib\site-packages\matplotlib\tests\test_mlab.py", line 409, in test_csv2txt_basic
assert_equal(mlab.rec2txt(a), truth)
AssertionError: ' x y s s2\r\n 1.000 2 foo bing \r\n 2.[16 chars]lah ' != ' x y s s2\n 1.000 2 foo bing \n 2.000 3 bar blah '

•    x   y   s    s2
  

  ? - -

•    x   y   s   s2
  

• 1.000 2 foo bing
  ? - -
• 1.000 2 foo bing
• 2.000 3 bar blah ? -
• 2.000 3 bar blah

---

Ran 5209 tests in 1399.371s

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#6423 (comment)

[tacaswell]

backported to v1.5.x as cab8cf7