Output pdf dicts in deterministic order #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we merge this as is or do you intend to add more commits to this? |
| r.extend([Name(key).pdfRepr() + b" " + pdfRepr(val) | ||
| for key, val in six.iteritems(obj)]) | ||
| r.extend([Name(key).pdfRepr() + b" " + pdfRepr(obj[key]) | ||
| for key in sorted(six.iterkeys(obj))]) |
There was a problem hiding this comment.
The iterkeys seems unnecessary if you're going to sort it anyway; sorted(obj) should work just fine.
There was a problem hiding this comment.
Thanks, that makes sense.
|
@tacaswell I think it's probably better to merge sooner, it's going to be some work to implement the rest and this could make it easier for someone else to get started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6317 (but not a complete solution for that)