Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Offset text colored by labelcolor param #6445
Conversation
mdboom
added the
needs_review
label
May 19, 2016
tacaswell
added this to the
2.1 (next point release)
milestone
May 19, 2016
|
|
|
Yup. Did so. |
|
In interest of keeping the repo size and test runtime down this test can probably just be checked by asserting that the offset text has the expected color. Can you make that small change and rebase the png out of existence? |
|
Yep. Fixed to just check label color. |
|
Thanks! |
tacaswell
merged commit 9e228e6
into matplotlib:master
May 19, 2016
tacaswell
removed the
needs_review
label
May 19, 2016
|
Should this be backported to 2.x ? |
jenshnielsen
referenced
this pull request
May 22, 2016
Closed
BUG: set_tick_params labelcolor should apply to offset #6440
|
I am +0.5 on back porting On Sun, May 22, 2016, 07:59 Jens Hedegaard Nielsen notifications@github.com
|
|
Now I see that this is fixing a bug that was tagged for 2.0, I'll do the backport. |
tacaswell
added a commit
that referenced
this pull request
May 22, 2016
|
|
tacaswell |
3df2df1
|
|
backported to v2.x as 3df2df1 |
bcongdon commentedMay 19, 2016
Addresses #6440.
Sets color of
offsetTextinset_tick_paramsto what thelabelcolordictates.