Offset text colored by labelcolor param #6445

Merged
merged 2 commits into from May 19, 2016

Conversation

Projects
None yet
4 participants
Contributor

bcongdon commented May 19, 2016

Addresses #6440.

Sets color of offsetText in set_tick_params to what the labelcolor dictates.

@bcongdon bcongdon labelcolor param now changes offset text color
a44f66e

mdboom added the needs_review label May 19, 2016

tacaswell added this to the 2.1 (next point release) milestone May 19, 2016

Owner

tacaswell commented May 19, 2016

👍 Can you add a test and a whats new entry?

Contributor

bcongdon commented May 19, 2016

Yup. Did so.
Not sure why the Travis build is failing, it passed on my fork.

Owner

tacaswell commented May 19, 2016

In interest of keeping the repo size and test runtime down this test can probably just be checked by asserting that the offset text has the expected color. Can you make that small change and rebase the png out of existence?

@bcongdon bcongdon Add offset label color test & what's new entry
fd8ec19
Contributor

bcongdon commented May 19, 2016

Yep. Fixed to just check label color.

Owner

tacaswell commented May 19, 2016

Thanks!

@tacaswell tacaswell merged commit 9e228e6 into matplotlib:master May 19, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 69.763%
Details

tacaswell removed the needs_review label May 19, 2016

Owner

jenshnielsen commented May 22, 2016

Should this be backported to 2.x ?

Owner

tacaswell commented May 22, 2016

I am +0.5 on back porting

On Sun, May 22, 2016, 07:59 Jens Hedegaard Nielsen notifications@github.com
wrote:

Should this be backported to 2.x ?


You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#6445 (comment)

Owner

tacaswell commented May 22, 2016

Now I see that this is fixing a bug that was tagged for 2.0, I'll do the backport.

@tacaswell tacaswell added a commit that referenced this pull request May 22, 2016

@tacaswell tacaswell Merge pull request #6445 from benjamincongdon/fix-label-color
Offset text colored by labelcolor param
3df2df1
Owner

tacaswell commented May 22, 2016

backported to v2.x as 3df2df1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment