/matplotlib

ENH: add unified seaborn style sheet #6467

Merged
merged 1 commit into from May 24, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
5 participants
@tacaswell @mwaskom @efiring @WeatherGod @mdboom
@tacaswell
Owner

tacaswell commented May 22, 2016

closes #6452

attn @mwaskom I think this is half of what you had in mind.

tacaswell added the needs_review label May 22, 2016

@mwaskom

mwaskom commented May 23, 2016

LGTM, thanks!
@efiring
Owner

efiring commented May 23, 2016

Is there a reason why it is called "sns" instead of "seaborn"?
@tacaswell
Owner

tacaswell commented May 23, 2016

sns is the normal import alias of seaborn and is less letters.

tacaswell added this to the 2.0 (style change major release) milestone May 23, 2016

@WeatherGod
Member

WeatherGod commented May 23, 2016

As someone who doesn't use seaborn, I wouldn't have guessed that "sns" was
the seaborn style.

On Sun, May 22, 2016 at 10:00 PM, Thomas A Caswell <notifications@github.com

wrote:

sns is the normal import alias of seaborn and is less letters.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#6467 (comment)
@tacaswell tacaswell ENH: add unified seaborn style sheet 
closes #6452

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 69.764%
Details
6d5a586
@tacaswell
Owner

tacaswell commented May 23, 2016

renamed to seaborn

@WeatherGod WeatherGod merged commit 8bab42d into matplotlib:master May 24, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.764%
Details

mdboom removed the needs_review label May 24, 2016

@WeatherGod
Member

WeatherGod commented May 24, 2016

this need to be backported at all?
@efiring
Owner

efiring commented May 24, 2016

Yes, it should go to v2.x.

@WeatherGod WeatherGod added a commit that referenced this pull request May 24, 2016

@WeatherGod WeatherGod Merge pull request #6467 from tacaswell/sty_single_sns_sheet 
ENH: add unified seaborn style sheet
 e70bc42
@WeatherGod
Member

WeatherGod commented May 24, 2016

backported to v2.x via e70bc42

tacaswell deleted the tacaswell:sty_single_sns_sheet branch Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment