Barchart demo example clean up [MEP 12] #6485

Merged
merged 1 commit into from May 27, 2016

Conversation

Projects
None yet
4 participants
Contributor

ckarako commented May 27, 2016

Added docstrings and changed mixcase variables in order to comply with PEP 8.

@ckarako ckarako Cleaned up: added docstrings and switched mixcase variables to comply…
… with PEP 8
39da3c3

mdboom added the needs_review label May 27, 2016

Owner

tacaswell commented May 27, 2016

👍 Looks good, will merge once CI passes.

After this is merged and CI runs again, these changes will be reflected at http://matplotlib.org/devdocs/examples/api/barchart_demo.html

Owner

tacaswell commented May 27, 2016

travis failure is unrelated.

@tacaswell tacaswell merged commit 8fd658b into matplotlib:master May 27, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 69.773%
Details

tacaswell removed the needs_review label May 27, 2016

Owner

tacaswell commented May 27, 2016

@ckarako Thank you! Documentation and examples are systematically undervalued, any help on them is great.

Hope to hear from you again.

ckarako deleted the ckarako:clean-up-barchart-example branch May 27, 2016

QuLogic added this to the 2.1 (next point release) milestone Jul 5, 2016

@tacaswell tacaswell added a commit that referenced this pull request Nov 11, 2016

@tacaswell tacaswell Merge pull request #6485 from ckarako/clean-up-barchart-example
DOC: Barchart demo example clean up [MEP 12]
ee74fd6
Owner

tacaswell commented Nov 11, 2016

backported to v2.x as ee74fd6

Backported this doc-only patch to make backporting some other PRs easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment