/matplotlib

Patch issue 6035 rebase #6504

Merged
merged 12 commits into from May 30, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
3 participants
@jenshnielsen @afvincent @tacaswell
@jenshnielsen
Owner

jenshnielsen commented May 30, 2016 • edited by QuLogic

Rebased and changed prepare method to be private to hopefully fix issue with tests.

I squashed 2 commits that changed the same figures to reduce the size of the repository.

Replaces #6054

jenshnielsen added the needs_review label May 30, 2016

jenshnielsen added this to the 2.0 (style change major release) milestone May 30, 2016

@tacaswell tacaswell merged commit 24c0863 into matplotlib:master May 30, 2016
1 of 3 checks passed

1 of 3 checks passed

coverage/coveralls Coverage decreased (-0.001%) to 69.592%
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label May 30, 2016

This was referenced May 30, 2016

Closed
Closed
@afvincent
Contributor

afvincent commented May 30, 2016

@jenshnielsen thank you for the solution about the remaining issue with test_artist.test_clipping. I wouldn't have find it.

@tacaswell tacaswell added a commit that referenced this pull request May 31, 2016

@tacaswell tacaswell Merge pull request #6504 from jenshnielsen/patch-issue-6035-rebase 
FIX: dpi dependent arrow heads
Conflicts:
	lib/matplotlib/tests/baseline_images/test_transforms/pre_transform_data.png

Keep version form cherry-pick

Manually backport part of bd63121 which
renamed the test files.
 72653f2
@tacaswell
Owner

tacaswell commented May 31, 2016

backported to v2.x as 72653f2

Did not go super cleanly due to a rename of test images.

@tacaswell tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 31, 2016

@tacaswell tacaswell TST: add small tolerances to streamplot tests 
These tests did not backport cleanly from
matplotlib#6504
 374b6c0

tacaswell referenced this pull request May 31, 2016

Merged

TST: add small tolerances to streamplot tests #6506

@jenshnielsen
Owner

jenshnielsen commented May 31, 2016

@afvincent No problem. For the record I found it because I noticed that the tests were not failing if run individually. If you add a --verbose to python tests.py you can also see that the prepare method was being run as a test.

jenshnielsen deleted the jenshnielsen:patch-issue-6035-rebase branch Sep 11, 2016

This was referenced Nov 3, 2016

Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment