Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch issue 6035 rebase #6504

Merged
merged 12 commits into from May 30, 2016

Conversation

jenshnielsen
Copy link
Member

@jenshnielsen jenshnielsen commented May 30, 2016

Rebased and changed prepare method to be private to hopefully fix issue with tests.

I squashed 2 commits that changed the same figures to reduce the size of the repository.

Replaces #6054

@jenshnielsen jenshnielsen added this to the 2.0 (style change major release) milestone May 30, 2016
@tacaswell tacaswell merged commit 24c0863 into matplotlib:master May 30, 2016
@afvincent
Copy link
Contributor

@jenshnielsen thank you for the solution about the remaining issue with test_artist.test_clipping. I wouldn't have find it.

tacaswell added a commit that referenced this pull request May 31, 2016
FIX: dpi dependent arrow heads
Conflicts:
	lib/matplotlib/tests/baseline_images/test_transforms/pre_transform_data.png

Keep version form cherry-pick

Manually backport part of bd63121 which
renamed the test files.
@tacaswell
Copy link
Member

backported to v2.x as 72653f2

Did not go super cleanly due to a rename of test images.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 31, 2016
These tests did not backport cleanly from
matplotlib#6504
@jenshnielsen
Copy link
Member Author

@afvincent No problem. For the record I found it because I noticed that the tests were not failing if run individually. If you add a --verbose to python tests.py you can also see that the prepare method was being run as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants