/matplotlib

Fix conversion of string grays with alpha. #6517

Merged
merged 1 commit into from Jun 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@anntzer @zblz @tacaswell @mdboom
@anntzer
Contributor

anntzer commented May 31, 2016

See #6513.
@anntzer anntzer Fix conversion of string grays with alpha.

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.001%) to 69.624%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
5fd8c76

mdboom added the needs_review label May 31, 2016

@zblz
Member

zblz commented Jun 1, 2016 • edited

Looks good to me, and definitely fixes #6513. I'll leave it up a couple of days in case somebody has a comment. Thanks for the quick fix!

tacaswell added this to the 2.0 (style change major release) milestone Jun 1, 2016

@zblz zblz merged commit 4ba20b8 into matplotlib:master Jun 3, 2016
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.001%) to 69.624%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mdboom removed the needs_review label Jun 3, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jun 3, 2016

@zblz @tacaswell zblz + tacaswell Merge pull request #6517 from anntzer/fix-string-gray-conversion 
Fix conversion of string grays with alpha.
 1e35d8d
@tacaswell
Owner

tacaswell commented Jun 3, 2016

backported to 2.x as 1e35d8d

tacaswell referenced this pull request Jun 3, 2016

Closed

Using gray shade from string ignores alpha parameters #6513

anntzer deleted the anntzer:fix-string-gray-conversion branch Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment