Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ttconv: Also replace carriage return with spaces. #6526
Conversation
QuLogic
added needs_review backend/ps and removed needs_review
labels
Jun 1, 2016
tacaswell
added this to the
2.0 (style change major release)
milestone
Jun 3, 2016
|
@mdboom should probably review this before it is merged. |
jenshnielsen
merged commit 494c4f6
into matplotlib:master
Jun 13, 2016
mdboom
removed the
needs_review
label
Jun 13, 2016
jenshnielsen
added a commit
that referenced
this pull request
Jun 13, 2016
|
|
jenshnielsen + jenshnielsen |
77caea0
|
|
Backported to 2.x as 77caea0 |
QuLogic
deleted the
QuLogic:ttconv-carriage-return branch
Jun 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
QuLogic commentedJun 1, 2016
Multi-line strings will cause issues in comments since the secondary lines will not be comments. This replacement is already done for newline characters (\n), but not carriage return (\r) which is prevalent on Windows.
I went with the simpler route of just replacing with a space instead of trying to compress
\r\nbecause that would require shifting the entire string and would be a more involved change.I assume that changing
ttconvis alright even though it's external since I can't find an upstream and there are already comments to the effect that it has already been modified.Fixes #5862.