/matplotlib

TST Remove plt.show() from test_axes.test_dash_offset #6529

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
5 participants
@afvincent @QuLogic @tacaswell @efiring @mdboom
@afvincent
Contributor

afvincent commented Jun 2, 2016

Remove the call to plt.show() in test_axes.test_dash_offset (as suggested in PR #5433). Previously, when running test_axes in an IPython session, a figure window was opened, waiting for the user to close it before running the remaining tests...
@afvincent afvincent TST Remove plt.show() from test_axes.test_dash_offset

All checks have failed

3 failing checks
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage decreased (-0.01%) to 69.616%
Details
80ffd04

mdboom added the needs_review label Jun 2, 2016

@afvincent
Contributor

afvincent commented Jun 2, 2016

How can removing this single line in test_axes.test_dash_offset cause a test failure of test_mathtext.test_mathfont_dejavuserif_11?

@efiring efiring merged commit 7f7080b into matplotlib:master Jun 2, 2016
0 of 3 checks passed

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.01%) to 69.616%
Details

efiring removed the needs_review label Jun 2, 2016

afvincent deleted the afvincent:TST_avoid_calling_show_in_test_dash_offset branch Jun 2, 2016

@QuLogic
Member

QuLogic commented Jun 2, 2016

This should probably be backported to 2.0 since that test was added there.
@tacaswell
Owner

tacaswell commented Jun 3, 2016

👍 to backporting

@efiring efiring added a commit that referenced this pull request Jun 3, 2016

@efiring efiring Merge pull request #6529 from afvincent/TST_avoid_calling_show_in_tes… 
…t_dash_offset

TST Remove plt.show() from test_axes.test_dash_offset
 debac32
@efiring
Owner

efiring commented Jun 3, 2016

Backported to v2.x as debac32

QuLogic added this to the 2.0 (style change major release) milestone Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment