Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Remove plt.show() from test_axes.test_dash_offset #6529

Conversation

afvincent
Copy link
Contributor

Remove the call to plt.show() in test_axes.test_dash_offset (as suggested in PR #5433). Previously, when running test_axes in an IPython session, a figure window was opened, waiting for the user to close it before running the remaining tests...

@afvincent
Copy link
Contributor Author

How can removing this single line in test_axes.test_dash_offset cause a test failure of test_mathtext.test_mathfont_dejavuserif_11?

@efiring efiring merged commit 7f7080b into matplotlib:master Jun 2, 2016
@afvincent afvincent deleted the TST_avoid_calling_show_in_test_dash_offset branch June 2, 2016 21:25
@QuLogic
Copy link
Member

QuLogic commented Jun 2, 2016

This should probably be backported to 2.0 since that test was added there.

@tacaswell
Copy link
Member

👍 to backporting

efiring added a commit that referenced this pull request Jun 3, 2016
…t_dash_offset

TST Remove plt.show() from test_axes.test_dash_offset
@efiring
Copy link
Member

efiring commented Jun 3, 2016

Backported to v2.x as debac32

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants