Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update make.py #6530
Conversation
mdboom
added the
needs_review
label
Jun 3, 2016
tacaswell
added this to the
2.0 (style change major release)
milestone
Jun 3, 2016
|
@efiring I think this should fix your issue building the docs? |
|
Im a bit worried about coping the users default rc file for generating the documentation. This can result in the documentation unintentionally being generated with a non default style. Would it not be better to refactor the code out from setup.py that generates the rc file from the template and call that as part of make.py? |
|
Is this rcparam actually used building the docs or is in just something we serve? |
|
@jenshnielsen is this ok? --- a/doc/make.py
+++ b/doc/make.py
@@ -38,7 +38,9 @@
def html(buildername='html'):
check_build()
- copy_if_out_of_date('../lib/matplotlib/mpl-data/matplotlibrc', '_static/matplotlibrc')
+ rc = '../lib/matplotlib/mpl-data/matplotlibrc'
+ rc = os.path.exists(rc) and rc or '../matplotlibrc.template'
+ copy_if_out_of_date(rc, '_static/matplotlibrc')
if small_docs:
options = "-D plot_formats=png:80"
else: |
|
It looks like it is used only here: |
|
So I guess we should reference That seems like default config, with only backend set. |
|
@klonuo I think that is correct. |
jenshnielsen
merged commit 2ac4e88
into matplotlib:master
Jun 13, 2016
mdboom
removed the
needs_review
label
Jun 13, 2016
|
@klonuo Thanks |
jenshnielsen
added a commit
that referenced
this pull request
Jun 13, 2016
|
|
jenshnielsen + jenshnielsen |
96fb3a3
|
|
backported to 2.x as 96fb3a3 |
klonuo commentedJun 3, 2016
Referencing #6527, these changes provide: