/matplotlib

Fix typo in margins handling. #6544

Merged
merged 1 commit into from Jun 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
5 participants
@anntzer @WeatherGod @jenshnielsen @mdboom @QuLogic
@anntzer
Contributor

anntzer commented Jun 6, 2016

This does not change the semantics of the code but should make things
clearer and offer a negligible optimization: previously, the margins
correction would be computed even if margin == 0 as long as
do_upper_margin was set.
@anntzer anntzer Fix typo in margins handling. 
This does not change the semantics of the code but should make things
clearer and offer a negligible optimization: previously, the margins
correction would be computed even if `margin == 0` as long as
`do_upper_margin` was set.

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 69.658%
Details
655f5ae

mdboom added the needs_review label Jun 6, 2016

@WeatherGod
Member

WeatherGod commented Jun 7, 2016

restarted the failing job. This change does make sense to me.
@WeatherGod
Member

WeatherGod commented Jun 7, 2016

I'm ready to merge this, but what are the backporting rules now?
@jenshnielsen
Owner

jenshnielsen commented Jun 7, 2016

I think this should be backported to 2.x but not 1.5.x since we are basically ready to release 1.5.2 and then not touch the branch after that.
@WeatherGod
Member

WeatherGod commented Jun 7, 2016

Makes sense to me

@WeatherGod WeatherGod merged commit 2303df6 into matplotlib:master Jun 7, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 69.658%
Details

mdboom removed the needs_review label Jun 7, 2016

@WeatherGod WeatherGod added a commit that referenced this pull request Jun 7, 2016

@WeatherGod WeatherGod Merge pull request #6544 from anntzer/margins-typo 
Fix typo in margins handling.
 077c72e
@WeatherGod
Member

WeatherGod commented Jun 7, 2016

backported as 077c72e

QuLogic added this to the 2.0 (style change major release) milestone Jun 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment