Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update mpl_toolkits.gtktools. #6554
Conversation
mdboom
added the
needs_review
label
Jun 8, 2016
|
@anntzer Thanks I am |
|
Added a deprecation message. |
tacaswell
added this to the
2.0 (style change major release)
milestone
Jun 8, 2016
|
we have exceltools?!? Maybe suggest using |
|
It's literally two functions on top of xlrd; I honestly can't imagine that anyone is relying on them... anyways, mentioned openpyxl as a replacement. |
|
We changed the ctor of CallbackRegistry years ago, IIRC. A bit telling, I also have no objections to deprecating these. I didn't even mention On Wed, Jun 8, 2016 at 11:57 AM, Antony Lee notifications@github.com
|
|
This needs a rebase (not sure why). |
|
done |
tacaswell
merged commit 1214b21
into matplotlib:master
Jun 20, 2016
tacaswell
removed the
needs_review
label
Jun 20, 2016
tacaswell
added a commit
that referenced
this pull request
Jun 20, 2016
|
|
tacaswell |
c1410f9
|
|
backported to v2.x as c1410f9 |
anntzer commentedJun 8, 2016
Actually, I'd rather just deprecate/kill gtktools and exceltools, which seem completely unmaintained and with no good reason to be shipped with matplotlib... but in case someone wants to keep them there:
__future__-imports unicode_strings).