Update mpl_toolkits.gtktools. #6554

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
5 participants
Contributor

anntzer commented Jun 8, 2016

Actually, I'd rather just deprecate/kill gtktools and exceltools, which seem completely unmaintained and with no good reason to be shipped with matplotlib... but in case someone wants to keep them there:

  • On Py2, np.rec.fromarrays cannot take a unicode string as names (but this module __future__-imports unicode_strings).
  • CallbackRegistry ctor signature has changed.

mdboom added the needs_review label Jun 8, 2016

Owner

jenshnielsen commented Jun 8, 2016

@anntzer Thanks I am 👍 on deprecating both of these. Do you want to add that here too?

Contributor

anntzer commented Jun 8, 2016

Added a deprecation message.

Owner

tacaswell commented Jun 8, 2016

we have exceltools?!?

Maybe suggest using pandas or openpyxl as an alternative to the excel tools?

Contributor

anntzer commented Jun 8, 2016

It's literally two functions on top of xlrd; I honestly can't imagine that anyone is relying on them... anyways, mentioned openpyxl as a replacement.

Member

WeatherGod commented Jun 8, 2016

We changed the ctor of CallbackRegistry years ago, IIRC. A bit telling,
methinks.

I also have no objections to deprecating these. I didn't even mention
gtktools in my book (slipped my mind).

On Wed, Jun 8, 2016 at 11:57 AM, Antony Lee notifications@github.com
wrote:

It's literally two functions on top of xlrd; I honestly can't imagine that
anyone is relying on them... anyways, mentioned openpyxl as a replacement.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6554 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-DXVa_3V7jPwRy7LGPriemVIxnZKks5qJuaEgaJpZM4Iwu4T
.

Owner

tacaswell commented Jun 19, 2016

This needs a rebase (not sure why).

@anntzer anntzer Update & deprecate mpl_toolkits.{gtk,excel}tools.
- On Py2, np.rec.fromarrays cannot take a unicode string as names (but
this module __future__-imports unicode_strings).

- CallbackRegistry ctor signature has changed.
9572d60
Contributor

anntzer commented Jun 20, 2016

done

@tacaswell tacaswell merged commit 1214b21 into matplotlib:master Jun 20, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.262%
Details

tacaswell removed the needs_review label Jun 20, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jun 20, 2016

@tacaswell tacaswell Merge pull request #6554 from anntzer/fix-gtktools
MNT: Update mpl_toolkits.gtktools.
c1410f9
Owner

tacaswell commented Jun 20, 2016

backported to v2.x as c1410f9

anntzer deleted the anntzer:fix-gtktools branch Jun 20, 2016

anntzer referenced this pull request Oct 16, 2016

Closed

Remove finance module #7071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment