Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Cleanup for drawstyles. #6564
Conversation
mdboom
added the
needs_review
label
Jun 9, 2016
|
https://travis-ci.org/matplotlib/matplotlib/jobs/136321898#L1084 Apparently that feature got in with out enough tests. |
tacaswell
added this to the
2.1 (next point release)
milestone
Jun 10, 2016
|
Fixed. I chose to normalize the input of |
tacaswell
merged commit c489bff
into matplotlib:master
Jun 19, 2016
tacaswell
removed the
needs_review
label
Jun 19, 2016
anntzer
deleted the
anntzer:cleanup-drawstyles branch
Jun 20, 2016
|
Actually, can we backport this to 2.0? Up to 1.5.1, opening the figure options editor after making a plot of drawstyle "steps-post" (for example) would print an error and mangle the drawstyle, which is bad, but still much better than the situation in 2.0b3 where an exception in thrown in the event loop (... and by default, PyQt5 aborts the program in such a case). |
|
Does the whole PR need to go back, or just the changes to |
|
I think the latter should be enough. |
|
@tacaswell should I open a new PR with just the changes to |
|
Can you do a PR with just the |
anntzer commentedJun 9, 2016
STEP_LOOKUP_MAP(plt.stepalreadynormalizes drawstyles to
step-*format).step-*drawstyles by the Qt options editor.