Fix mlab.rec_join. #6577

Merged
merged 1 commit into from Jun 19, 2016

Conversation

Projects
None yet
5 participants
Contributor

anntzer commented Jun 13, 2016

examples/misc/rec_lab_demo.py was broken on Python3.

Any plans to just deprecate most of mlab? I can see why it's there but nowadays pandas and friends are much more appropriate for this kind of stuff.

@anntzer anntzer Fix mlab.rec_join.
`examples/misc/rec_lab_demo.py` was broken on Python3.
90a7133

mdboom added the needs_review label Jun 13, 2016

Owner

tacaswell commented Jun 13, 2016

Yes, but we do not have any idea what people are actually using. For example the LIGO notebooks used some stuff from mlab (the power spectrum).

Contributor

anntzer commented Jun 13, 2016

Well, won't a standard deprecation cycle be enough?

Member

WeatherGod commented Jun 13, 2016

This stuff has been in matplotlib for a very long time. We would need a
few cycles for deprecation, and we should be providing clear replacements
in the deprecation notes.

On Mon, Jun 13, 2016 at 2:24 PM, Antony Lee notifications@github.com
wrote:

Well, won't a standard deprecation cycle be enough?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6577 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-OnE_tTXl7CfRMcgOvtA0WLSYpW0ks5qLaBMgaJpZM4Iz_V2
.

Contributor

anntzer commented Jun 13, 2016

I certainly understand, and wouldn't have suggested it if I didn't find parts of the code that are broken. The alternative would be to improve the coverage, which is so-so right now (this is actually the kind of code for which high coverage could be achieved).

@tacaswell tacaswell merged commit 0d33b1f into matplotlib:master Jun 19, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 69.608%
Details

tacaswell removed the needs_review label Jun 19, 2016

anntzer deleted the anntzer:fix-mlab-rec-join branch Jun 20, 2016

Member

QuLogic commented Oct 15, 2016

Indirectly backported to v2.x as cbec32b via #6868.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment