Added a new example to create error boxes using a PatchCollection

[tmdavison]

Adding a new example I first created here: http://stackoverflow.com/a/37856171/588071

[tacaswell]

Thanks for doing this!

Can you run this through a pep8 linter?

closes #6593

[tmdavison]

No problem, I think that should be ok now?

[WeatherGod]

I forget, did we want examples to have functions like this when it is just being called once? I thought it was only desirable to do for the examples to de-duplicate code?

[QuLogic]

I agree, in such a short example, there's not much benefit to this function, and there are more than enough comments to make it clear what all the code is doing.

[WeatherGod]

do we need to do this? the less code, the better, I would think.

[tmdavison]

agreed, I've removed it now

[WeatherGod]

should we be making this boxes before calling errorbar() so that the boxes appear below the errorbars?

[QuLogic]

That depends on the zorder, not when it's put on the axes, no?

[tacaswell]

I think examples should always be functions so that users can copy-paste
use them.

On Thu, Jun 16, 2016, 15:22 Benjamin Root notifications@github.com wrote:

In examples/statistics/errorbars_and_boxes.py
#6596 (comment):

• Create list for all the error patches

• errorboxes = []

• Loop over data points; create box from errors at each point

• for xc, yc, xe, ye in zip(xdata, ydata, xerror.T, yerror.T):

•    rect = Rectangle((xc-xe[0], yc-ye[0]), xe.sum(), ye.sum())
  

•    errorboxes.append(rect)
  

• Create patch collection with specified colour/alpha

• pc = PatchCollection(errorboxes, facecolor=fc, alpha=alpha, edgecolor=ec)

• Add collection to axes

• ax.add_collection(pc)

+# Call function to create error boxes
+makeErrorBoxes(x, y, xerr, yerr)

should we be making this boxes before calling errorbar() so that the
boxes appear below the errorbars?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/matplotlib/matplotlib/pull/6596/files/7f412e8d59060ce61af0f111d70bc42c5c15985e#r67408151,
or mute the thread
https://github.com/notifications/unsubscribe/AAMMhXKKiv5idEDU6eJ_NxIHyM93Jpj1ks5qMaKJgaJpZM4I3grL
.

[efiring]

Maybe not always, but in cases where they encapsulate reusable functionality, yes. In the present case, the function needs to include ax as an initial argument.

[anntzer]

Some suggestions (partially rendundant with other comments):

• Rename function to plot_error_boxes; pass ax as first argument, and include the call to errorbar within the function.
• Either write a complete docstring, or just drop it. (Documenting makeErrorBoxes as "Function to create error boxes" is... not very helpful.)

[WeatherGod]

does this get backported anywhere?

[jenshnielsen]

I think it should go into 2.x too

[WeatherGod]

backported to v2.x via 9ea7315