/matplotlib

BF: protect against locale in sphinext text #6601

Merged
merged 1 commit into from Jul 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@matthew-brett @QuLogic @tacaswell @mdboom
@matthew-brett
Contributor

matthew-brett commented Jun 18, 2016

The sphinxext tests were loading a text file with encoding not stated,
making the test sensitive to the default locale of the testing machine.

See:
https://travis-ci.org/matthew-brett/matplotlib-wheels/jobs/138518917#L8787

Read the text file as binary to avoid need for encoding.
@matthew-brett matthew-brett BF: protect against locale in sphinext text 
The sphinxext tests were loading a text file with encoding not stated,
making the test sensitive to the default locale of the testing machine.

See:
https://travis-ci.org/matthew-brett/matplotlib-wheels/jobs/138518917#L8787

Read the text file as binary to avoid need for encoding.

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.002%) to 70.262%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
2b4d2dc

mdboom added the needs_review label Jun 18, 2016

@tacaswell tacaswell merged commit b1d9443 into matplotlib:master Jul 2, 2016
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 70.262%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Jul 2, 2016

@QuLogic
Member

QuLogic commented Jul 5, 2016

This should probably be backported?

@tacaswell tacaswell added a commit that referenced this pull request Jul 10, 2016

@tacaswell tacaswell Merge pull request #6601 from matthew-brett/protect-against-locale 
BF: protect against locale in sphinext text

Conflicts:
	lib/matplotlib/sphinxext/tests/test_tinypages.py
	    backport minimal changes
 76fd818
@tacaswell
Owner

tacaswell commented Jul 10, 2016

(finally) Backported to v2.x as 76fd818

QuLogic added this to the 2.0 (style change major release) milestone Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment