Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix image alpha #6659
Conversation
mdboom
added some commits
Jun 28, 2016
mdboom
added this to the
2.0 (style change major release)
milestone
Jun 28, 2016
mdboom
added the
needs_review
label
Jun 28, 2016
tacaswell
merged commit 31be20b
into matplotlib:master
Jun 29, 2016
tacaswell
removed the
needs_review
label
Jun 29, 2016
tacaswell
added a commit
that referenced
this pull request
Jun 29, 2016
|
|
tacaswell |
c0d4321
|
|
backported to v2.x as c0d4321 |
QuLogic
added the
Alpha color
label
Sep 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mdboom commentedJun 28, 2016
Fixes #6540 in a different way than #6551. It turns out the vector backends were already correct and the only bug was in the agg backend. So this just updates the agg backend to ignore the alpha on images.
This is because for the case of interpolation=='none' in a vector backend we explicitly do not want to touch the image data at all, so the alpha must be applied in the vector renderer instructions, not in the image data itself.
The Agg backend doesn't really make sense for that and we always transform the image, so it is a special case.
Cc: @tacaswell