/matplotlib

Fixed AppVeyor building script #6676

Merged
merged 1 commit into from Jul 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
OS/Microsoft Testing
Projects
None yet
Milestone
  2.1 (next point r...
5 participants
@Kojoley @tacaswell @janschulz @mdboom @QuLogic
@Kojoley
Member

Kojoley commented Jul 2, 2016

No description provided.

@Kojoley Kojoley Fixed Appveyor building script

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
coverage/coveralls — Coverage remained the same at 70.273%
Details
4a76c0f

mdboom added the needs_review label Jul 2, 2016

Kojoley changed the title from Fixed Appveyor building script to Fixed AppVeyor building script Jul 2, 2016

@Kojoley
Member

Kojoley commented Jul 2, 2016

Oh. It is fixed in PR #6520 with 9af6ae0 but still not merged

Kojoley closed this Jul 2, 2016

mdboom removed the needs_review label Jul 2, 2016

@tacaswell
Owner

tacaswell commented Jul 3, 2016

Why did this pass but #6520 is still failing? attn @janschulz
@janschulz
Contributor

janschulz commented Jul 3, 2016

Because in master, the conda build is still disabled:https://github.com/Kojoley/matplotlib/blob/4a76c0fc06f95fdc3abeeb5119ab3f4f4965e7cb/appveyor.yml#L115

IMO this should be merged, I will rebase mine on top of it -> reopen and merge...

janschulz reopened this Jul 3, 2016

mdboom added the needs_review label Jul 3, 2016

@tacaswell tacaswell merged commit d0ac9fe into matplotlib:master Jul 3, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 70.273%
Details

tacaswell removed the needs_review label Jul 3, 2016

@tacaswell
Owner

tacaswell commented Jul 3, 2016

👍 I hit the merge button as soon as it was green (travis failure was unrelated / a known flaky test).
@janschulz
Contributor

janschulz commented Jul 3, 2016

Thanks!

QuLogic added this to the 2.1 (next point release) milestone Jul 3, 2016

@QuLogic QuLogic added OS/Microsoft Testing labels Jul 3, 2016

tacaswell referenced this pull request Jul 7, 2016

Closed

appveyor is failing on pre-install #6657

Kojoley deleted the Kojoley:fix-appveyor-build branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment