Merged _bool from axis into cbook._string_to_bool

[Kojoley]

No description provided.

[efiring]

For this to be a general cbook function, I think it should accept case-insensitive "true" and "false" as well as "on" and "off".

[Kojoley]

Yes, I thought about it. I will add them then.

[tacaswell]

This makes the kwargs a bit more permissive in what they accept (which seems ok).

Why make the function public?

[Kojoley]

Any reasons why it should not? I think that private functions should not be used outside of the module while this function is used in multiple external places.

[tacaswell]

The convention we use is that we can use private functions across modules within the project.

If it is public and we change it that is an API break,

[Kojoley]

I see no problem with making it public as it is quite simple and should not be changed frequently (or even at all). If my position is wrong then I will remake it private.

[WeatherGod]

You'd be surprise what changes. More precisely, you'd be surprised how many
people complain when old, unused functions are removed. Since this
function does not have anything to do with plotting, it would make sense to
keep it private to keep people from depending on matplotlib for
non-plotting use-cases.

On Tue, Jul 5, 2016 at 10:06 AM, Nikita Kniazev notifications@github.com
wrote:

I see no problem with making it public as it is quite simple and should
not be changed frequently (or even at all). If my position is wrong then I
will remake it private.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6686 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-PxEbTWvHdAxXv-0-q4X7Kh_IoHLks5qSmTwgaJpZM4JEeu2
.

[Kojoley]

Hmm. I see your point and it is strong, but the whole cbook is not about plotting and most functions it contains are public... why module itself is public then?

[WeatherGod]

We were young... we were foolish...

On Tue, Jul 5, 2016 at 10:58 AM, Nikita Kniazev notifications@github.com
wrote:

Hmm. I see your point and it is strong, but the whole cbook is not about
plotting and most functions it contains are public... why module itself is
public then?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6686 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AARy-HttQ0OvDLoyhokR-_odq5Lzmo06ks5qSnEhgaJpZM4JEeu2
.

[tacaswell]

Also, I suspect the existence of cbook pre-dates the convention that a leading underscore means 'private'.

[dopplershift]

Well, I think cbook also started as a landing site for things borrowed from places like: https://code.activestate.com/recipes/langs/python/

[tacaswell]

@Kojoley Thanks!