/matplotlib

DOC: fix radial increase of size & OO style in polar_scatter_demo #6688

Merged
merged 1 commit into from Jul 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  v2.0.0
4 participants
@afvincent @NelleV @QuLogic @mdboom
@afvincent
Contributor

afvincent commented Jul 4, 2016

Should fix #6687

I also tweaked the header docstring to wrap it slightly before col. 79.
@afvincent afvincent Fix radial increase of size & OO style

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 70.275%
Details
d534484

afvincent added the Documentation label Jul 4, 2016

afvincent added this to the 2.0.1 (next bug fix release) milestone Jul 4, 2016

mdboom added the needs_review label Jul 4, 2016

afvincent changed the title from Fix radial increase of size & OO style to DOC: fix radial increase of size & OO style in polar_scatter_demo Jul 4, 2016

@afvincent
Contributor

afvincent commented Jul 4, 2016

Additional question because I've seen both in the example gallery: when using a colormap in an example, is it preferred to simply call plt.cm.*colormap_name* or to first import matplotlib.cm as cm and then call the colormap where it is needed with cm.*colormap_name*?
@NelleV
Contributor

NelleV commented Jul 4, 2016

Both are fine. I have a slight preference for the latter, but it is personal.
Thanks for the patch!

@NelleV NelleV merged commit 5dfe000 into matplotlib:master Jul 4, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.275%
Details

mdboom removed the needs_review label Jul 4, 2016

@afvincent
Contributor

afvincent commented Jul 5, 2016

@NelleV Thank you for the explanations about calling a colormap.

afvincent deleted the afvincent:fix_polar_scatter_demo branch Jul 5, 2016

@QuLogic QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016

@NelleV @QuLogic NelleV + QuLogic Merge pull request #6688 from afvincent/fix_polar_scatter_demo 
DOC: fix radial increase of size & OO style in polar_scatter_demo
 70b851f
@QuLogic
Member

QuLogic commented Oct 16, 2016

Backported to v2.x via 70b851f.

@QuLogic QuLogic modified the milestone: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment