/matplotlib

Fixed path caching bug in `Path.unit_regular_star` #6697

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@Kojoley @mdboom @tacaswell @QuLogic
@Kojoley
Member

Kojoley commented Jul 6, 2016

No description provided.

@Kojoley Kojoley Fixed path caching bug in `Path.unit_regular_star`

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.002%) to 70.273%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
1b80a5c

mdboom added the needs_review label Jul 6, 2016

@Kojoley
Member

Kojoley commented Jul 6, 2016

Any reason for implementing cache with WeakValueDictionary? I see no problem just to use dict here.
I think this place is where functools.lru_cache decorator can be used (but with some python 2 fallback)
@mdboom
Owner

mdboom commented Jul 6, 2016

👍 from me

@tacaswell tacaswell merged commit 3590ce2 into matplotlib:master Jul 6, 2016
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 70.273%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Jul 6, 2016

@tacaswell
Owner

tacaswell commented Jul 6, 2016

Thanks!

QuLogic added this to the 2.1 (next point release) milestone Jul 6, 2016

Kojoley deleted the Kojoley:fix-path-cache-in-unit_regular_star branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment