Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fixed font_manager.is_opentype_cff_font() #6714
Conversation
mdboom
added the
needs_review
label
Jul 9, 2016
tacaswell
added this to the
2.0.1 (next bug fix release)
milestone
Jul 9, 2016
|
Is it possible to get a CFF font on travis? |
|
It is hard to find a free, raw otf file available for download, what I could find is this one: https://github.com/cozy/cozy-files/raw/a8681c82e97339deb8e4c0abda8b98c0b57d3b35/client/app/assets/fonts/maven-pro-light-300.otf |
|
It is not clear to me what the license on that file is (and it does not appear to be in their tree anymore). It looks like https://www.gnu.org/software/freefont/license.html are available on travis (https://github.com/travis-ci/apt-package-whitelist/pull/944/files). I have verified 'by hand' that this works, will put in another PR with a test. |
tacaswell
merged commit a18dd50
into matplotlib:master
Jul 12, 2016
tacaswell
removed the
needs_review
label
Jul 12, 2016
tacaswell
added a commit
that referenced
this pull request
Jul 12, 2016
|
|
tacaswell |
03775bb
|
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
|
|
tacaswell |
f2af658
|
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
|
|
tacaswell |
50e06d7
|
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 12, 2016
|
|
tacaswell |
9b2a886
|
QuLogic
modified the milestone: 2.0 (style change major release), 2.0.1 (next bug fix release)
Jul 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
deeenes commentedJul 9, 2016
font_manager.is_opentype_cff_font()gives false result because compares bytes to str. This won't cause trouble in Py2, but in Py3 results in callingEmbedTTFType3, and makes impossible to use CFF fonts. With setting the literal to type of bytes, it works fine.