/matplotlib

Fix crash if byte-compiled level 2 #6729

Merged
merged 3 commits into from Jul 12, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@JGoutin @tacaswell @QuLogic @mdboom
@JGoutin
Contributor

JGoutin commented Jul 12, 2016

Follow #6719

JGoutin added some commits Jul 12, 2016

@JGoutin JGoutin Update axes3d.py d658f9d
@JGoutin JGoutin Update .travis.yml

Some checks were not successful

1 errored and 2 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 70.33%
Details
c04c96d

mdboom added the needs_review label Jul 12, 2016

JGoutin referenced this pull request Jul 12, 2016

Closed

Fix crash if byte-compiled level 2 #6719

@JGoutin JGoutin Print byte-compilation level for debug 
Help see if `.travis.yml` work as intended.

Some checks were not successful

2 errored and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
coverage/coveralls — Coverage remained the same at 70.33%
Details
5f395e0

QuLogic added this to the 2.1 (next point release) milestone Jul 12, 2016

@JGoutin
Contributor

JGoutin commented Jul 12, 2016

The Travis test with -OO work as intended.

And, tests completed without error. There is no other crash like this.
@tacaswell
Owner

tacaswell commented Jul 12, 2016

👍 Thanks
@QuLogic
Member

QuLogic commented Jul 12, 2016

You've only added -OO to the test run. Does the -OO actually apply to the matplotlib files that are already installed?
@tacaswell
Owner

tacaswell commented Jul 12, 2016

From reading the docs, it will regenerate the byte code if needed.

tacaswell closed this Jul 12, 2016

tacaswell reopened this Jul 12, 2016

@tacaswell tacaswell added needs_review and removed needs_review labels Jul 12, 2016

@tacaswell tacaswell merged commit cb00f0b into matplotlib:master Jul 12, 2016
1 of 3 checks passed

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls Coverage remained the same at 70.33%
Details

tacaswell removed the needs_review label Jul 12, 2016

@tacaswell
Owner

tacaswell commented Jul 12, 2016

Sorry, clicked the wrong button.

JGoutin deleted the JGoutin:patch-1 branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment