Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
register IPython's eventloop integration in plt.install_repl_displayhook #6734
Conversation
mdboom
added the
needs_review
label
Jul 13, 2016
jenshnielsen
added this to the
2.0 (style change major release)
milestone
Jul 13, 2016
minrk
referenced
this pull request
in ipython/ipykernel
Jul 14, 2016
Merged
Make inline the default matplotlib backend #159
tacaswell
commented on the diff
Jul 14, 2016
| @@ -154,6 +155,13 @@ def post_execute(): | ||
| _IP_REGISTERED = post_execute | ||
| _INSTALL_FIG_OBSERVER = False | ||
| + | ||
| + # trigger IPython's eventloop integration, if available | ||
| + from IPython.core.pylabtools import backend2gui | ||
| + | ||
| + ipython_gui_name = backend2gui.get(get_backend()) |
minrk
Contributor
|
tacaswell
referenced
this pull request
in syl20bnr/spacemacs
Jul 14, 2016
Closed
IPython 5 will cause problems. #6580
|
Closing and reopening to run with miktex changes on appveyor to see if that lets the appveyor tests pass. |
janschulz
closed this
Jul 15, 2016
janschulz
reopened this
Jul 15, 2016
mdboom
added needs_review and removed needs_review
labels
Jul 15, 2016
|
For information, for the moment mpl is quite unusable with IPython 5 when using an interactive session. import matplotlib.pyplot as plt
plt.ion()
fig = plt.figure()I have to use The issue doesn't not occur when I don't use an interactive session, and call |
|
@afvincent just run |
|
The windows failure looks tex related. |
|
@tacaswell : thank you, with the magic command, everything is fine. It seems that I never looked carefully enough to the docs to notice the lines about using |
Seems that the fix in master isn't picked up here :-/ |
|
pep8 that is definitly not @minrk 's fault, merging as-is. |
tacaswell
merged commit e940795
into matplotlib:master
Jul 16, 2016
tacaswell
removed the
needs_review
label
Jul 16, 2016
tacaswell
added a commit
that referenced
this pull request
Jul 16, 2016
|
|
tacaswell |
a61f763
|
|
backported to v2.x as a61f763 |
minrk
deleted the
minrk:ipython-eventloops branch
Jul 16, 2016
This was referenced Jul 26, 2016
|
cherry-picked back to 1.5.x as 44c206b |
tacaswell
added a commit
that referenced
this pull request
Sep 8, 2016
|
|
tacaswell |
44c206b
|
minrk commentedJul 13, 2016
•
edited
Registers eventloop integration for IPython on setup, avoiding hangs when IPython hasn't been told about matplotlib prior to plotting.
The IPython kernel (notebook, qtcosole) has always needed this to avoid hangs if plotting happens prior to
%matplotlibmagic, but it was less important for terminal IPython < 5.0. Terminal IPython 5.0's adoption of prompt_toolkit means that it has the same eventloop requirements of the kernel, so it's now important in both contexts to avoid hangs.cc @tacaswell