Added missing side tick rcParams #6735

bcongdon · Jul 13, 2016

Addresses #6691.

Adds <x/y>tick.<major/minor>.* for configuring which side ticks are drawn via rcParams.

Per this change, similar tags like xtick.top and xtick.minor.top are and'ed to get the actual tick draw status.

where

This alignment is a bit confusing. I'm pretty sure you could put each parameter on its own line with an extra indent, and it should fix within 79 chars.

I agree that is a bit confusing, however they both don't fit on the same line within 79 characters.

Bottom is the longest, and should be 79 if moved to its own line. I mean like this:

        self.tick_params(
            top=...
            bottom=...
            ...)

Right. Thanks!

Extra blank line.

Fixed.

janschulz · Jul 15, 2016

Closing and reopening to run with miktex changes on appveyor to see if that lets the appveyor tests pass.

QuLogic · Jul 17, 2016

Backported to v2.x as 4721d2e.

bcongdon Added major/minor tick visibility params fc7c026

mdboom added the needs_review label Jul 13, 2016

janschulz closed this Jul 15, 2016

janschulz reopened this Jul 15, 2016

mdboom added needs_review and removed needs_review labels Jul 15, 2016

tacaswell modified the milestone: 2.0 (style change major release) Jul 16, 2016

tacaswell removed the needs_review label Jul 16, 2016

QuLogic added a commit that referenced this pull request Jul 17, 2016

tacaswell + QuLogic Merge pull request #6735 from bcongdon/feature_rcParam_side_tick
ENH: Added missing side tick rcParams
4721d2e

@@ -5,6 +5,11 @@ The parameters ``xtick.top``, ``xtick.bottom``, ``ytick.left``
      and ``ytick.right`` were added to control where the ticks
      are drawn.
+    +Furthermore, the parameters ``xtick.major.top``, ``xtick.major.bottom``,
+    +``xtick.minor.top``, ``xtick.minor.bottom``, ``ytick.major.left``,
+    +``ytick.major.right``, ``ytick.minor.left``, and ``ytick.minor.right`` were
+    +added to control were ticks are drawn.

@@ -566,11 +566,26 @@ def __init__(self, fig, rect,
              if self.yaxis is not None:
                  self._ycid = self.yaxis.callbacks.connect('units finalize',
                                                            self.relim)
-    -        self.tick_params(top=rcParams['xtick.top'],
-    -                         bottom=rcParams['xtick.bottom'],
-    -                         left=rcParams['ytick.left'],
-    -                         right=rcParams['ytick.right'],
-    -                         which='both')
+    +
+    +        self.tick_params(top=rcParams['xtick.top'] and
+    +                         rcParams['xtick.minor.top'],

@@ -1175,6 +1175,12 @@ def validate_animation_writer_path(p):
          'xtick.color':       ['k', validate_color],  # color of the xtick labels
          'xtick.minor.visible':   [False, validate_bool],    # visiablility of the x axis minor ticks
+    +    'xtick.minor.top':   [True, validate_bool],  # draw x axis top minor ticks
+    +    'xtick.minor.bottom':    [True, validate_bool],    # draw x axis bottom minor ticks
+    +    'xtick.major.top':   [True, validate_bool],  # draw x axis top major ticks
+    +    'xtick.major.bottom':    [True, validate_bool],    # draw x axis bottom major ticks
+    +

matplotlib/matplotlib

Added missing side tick rcParams #6735

bcongdon commented Jul 13, 2016

mdboom added the needs_review label Jul 13, 2016

QuLogic commented on the diff Jul 13, 2016

QuLogic and 1 other commented on an outdated diff Jul 13, 2016

QuLogic and 1 other commented on an outdated diff Jul 13, 2016

janschulz commented Jul 15, 2016

janschulz closed this Jul 15, 2016

janschulz reopened this Jul 15, 2016

mdboom added needs_review and removed needs_review labels Jul 15, 2016

tacaswell modified the milestone: 2.0 (style change major release) Jul 16, 2016

tacaswell merged commit `b9aedb8` into matplotlib:master Jul 16, 2016
2 of 3 checks passed

2 of 3 checks passed

tacaswell removed the needs_review label Jul 16, 2016

QuLogic added a commit that referenced this pull request Jul 17, 2016

QuLogic commented Jul 17, 2016 • edited

matplotlib/matplotlib

Join GitHub today

Added missing side tick rcParams #6735

Conversation

bcongdon commented Jul 13, 2016

mdboom added the needs_review label Jul 13, 2016

QuLogic commented on the diff Jul 13, 2016

QuLogic Jul 13, 2016

Show 4 comments Hide comments QuLogic and 1 other commented on an outdated diff Jul 13, 2016

QuLogic Jul 13, 2016

bcongdon Jul 13, 2016

QuLogic Jul 13, 2016

bcongdon Jul 13, 2016

Show 2 comments Hide comments QuLogic and 1 other commented on an outdated diff Jul 13, 2016

QuLogic Jul 13, 2016

bcongdon Jul 13, 2016

Some checks were not successful

janschulz commented Jul 15, 2016

janschulz closed this Jul 15, 2016

janschulz reopened this Jul 15, 2016

mdboom added needs_review and removed needs_review labels Jul 15, 2016

tacaswell modified the milestone: 2.0 (style change major release) Jul 16, 2016

Hide details View details tacaswell merged commit b9aedb8 into matplotlib:master Jul 16, 2016 2 of 3 checks passed

2 of 3 checks passed

tacaswell removed the needs_review label Jul 16, 2016

QuLogic added a commit that referenced this pull request Jul 17, 2016

QuLogic commented Jul 17, 2016 • edited

QuLogic and 1 other commented on an outdated diff Jul 13, 2016

QuLogic and 1 other commented on an outdated diff Jul 13, 2016

tacaswell merged commit `b9aedb8` into matplotlib:master Jul 16, 2016
2 of 3 checks passed