Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Missing `cleanup` decorator in `test_subplots.test_exceptions` #6741
Conversation
mdboom
added the
needs_review
label
Jul 14, 2016
|
Looks good. It might resolve some of the intermittent failures on Nose too There seems to be a typo in the test comments |
|
@janschulz Any idea what happens to Appveyor here? |
|
|
|
Is this also from miktex?
[from https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2039/job/jmlxickc9a0u510j] I think the easiest would be to pin miktext to the old version for now... Will add a PR for that... and then try to understand whats going wrong here :-/ |
janschulz
referenced
this pull request
Jul 15, 2016
Merged
Add workaround for failures due to newer miktex #6744
|
PW in #6744, will merge if that passes the appveyor tests |
jenshnielsen
merged commit d498f56
into matplotlib:master
Jul 15, 2016
jenshnielsen
removed the
needs_review
label
Jul 15, 2016
jenshnielsen
added a commit
to jenshnielsen/matplotlib
that referenced
this pull request
Jul 15, 2016
|
|
jenshnielsen + jenshnielsen |
74b634e
|
|
backported to 2.x via 74b634e |
Kojoley commentedJul 14, 2016
•
edited
pytestfails intest_subplots.test_subplots_offsettextbecause of missing cleanup, whilenoseis fine