Missing `cleanup` decorator in `test_subplots.test_exceptions` #6741

Merged
merged 3 commits into from Jul 15, 2016

Conversation

Projects
None yet
5 participants
Member

Kojoley commented Jul 14, 2016 edited

pytest fails in test_subplots.test_subplots_offsettext because of missing cleanup, while nose is fine

Kojoley added some commits Jul 14, 2016

@Kojoley Kojoley Missing `cleanup` decorator in `test_subplots.test_exceptions` f31d7c4
@Kojoley Kojoley Remove duplicates in `test_subplots`
f80fb74

mdboom added the needs_review label Jul 14, 2016

Owner

jenshnielsen commented Jul 15, 2016

Looks good. It might resolve some of the intermittent failures on Nose too

There seems to be a typo in the test comments # the pount of this test is to ensure that this raises. can you change that to point

@Kojoley Kojoley Fixed typo in `test_subplots.test_exceptions`
245481d
Owner

jenshnielsen commented Jul 15, 2016

@janschulz Any idea what happens to Appveyor here?

Member

Kojoley commented Jul 15, 2016

miktex has updated and something is wrong with them

Contributor

janschulz commented Jul 15, 2016

Is this also from miktex?

======================================================================
ERROR: matplotlib.tests.test_dviread.test_dviread
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Miniconda-x64\envs\test-environment\lib\site-packages\nose\case.py", line 197, in runTest
    self.test(*self.arg)
  File "c:\projects\matplotlib\lib\matplotlib\tests\test_dviread.py", line 77, in test_dviread
    for page in dvi]
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 239, in __iter__
    have_page = self._read()
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 300, in _read
    self._dtable[byte](self, byte)
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 164, in wrapper
    return method(self, *[f(self, byte-min) for f in get_args])
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 447, in _fnt_def
    self._fnt_def_real(k, c, s, d, a, l)
  File "c:\projects\matplotlib\lib\matplotlib\dviread.py", line 458, in _fnt_def_real
    raise error_class("missing font metrics file: %s" % fontname)
OSError: missing font metrics file: cmr10

[from https://ci.appveyor.com/project/mdboom/matplotlib/build/1.0.2039/job/jmlxickc9a0u510j]

I think the easiest would be to pin miktext to the old version for now... Will add a PR for that... and then try to understand whats going wrong here :-/

Contributor

janschulz commented Jul 15, 2016 edited

PW in #6744, will merge if that passes the appveyor tests

@jenshnielsen jenshnielsen merged commit d498f56 into matplotlib:master Jul 15, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.364%
Details

@jenshnielsen jenshnielsen added a commit to jenshnielsen/matplotlib that referenced this pull request Jul 15, 2016

@jenshnielsen @jenshnielsen jenshnielsen + jenshnielsen Merge pull request #6741 from Kojoley/missing-cleanup-decorator
Missing `cleanup` decorator in `test_subplots.test_exceptions`
74b634e
Owner

jenshnielsen commented Jul 15, 2016

backported to 2.x via 74b634e

Kojoley referenced this pull request Jul 16, 2016

Open

Migration to Py.test testing framework #6731

28 of 39 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment