DOC: clean up of demo_annotation_box.py #6760

Merged
merged 1 commit into from Jul 16, 2016

Conversation

Projects
None yet
5 participants
Contributor

afvincent commented Jul 16, 2016

Clean up of pylab_examples/demo_annotation_box.py:

  • moves all imports to the head of the script;
  • reorganizes and adds comments to make the different steps more obvious;
  • removes the final plt.draw call;
  • loads Grace Hopper's portrait with plt.imread instead of _png.read_png, which (at least) avoids an additional import (besides, is the _png supposed to be exposed in a pylab example?).
@afvincent afvincent Clean up of demo_annotation_box.py
d5f6807

mdboom added the needs_review label Jul 16, 2016

Contributor

afvincent commented Jul 16, 2016

It looks to me that the Travis pep8 failure is not related the current PR (the incriminated file is test_backend_svg.py…), but tell me if I'm wrong and I will re-check the pep8-ness of the file I've modified.

Member

WeatherGod commented Jul 16, 2016

yeah, the fix for that is in master now, so don't fret it.

@WeatherGod WeatherGod merged commit 2f2b08d into matplotlib:master Jul 16, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
coverage/coveralls Coverage remained the same at 70.36%
Details

mdboom removed the needs_review label Jul 16, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jul 16, 2016

@WeatherGod @tacaswell WeatherGod + tacaswell Merge pull request #6760 from afvincent/fix_demo_annotation_box
DOC: clean up of demo_annotation_box.py
6b3622a
Owner

tacaswell commented Jul 16, 2016

backported to v2.x as 6b3622a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment