/matplotlib

Fixed warnings catching and counting with `warnings.catch_warnings` #6761

Merged
merged 1 commit into from Jul 16, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
4 participants
@Kojoley @tacaswell @QuLogic @mdboom
@Kojoley
Member

Kojoley commented Jul 16, 2016

No description provided.

@Kojoley Kojoley Fixed warnings catching and counting with `warnings.catch_warnings`

Some checks were not successful

1 errored, 1 failing, and 1 successful checks
continuous-integration/appveyor/pr — AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
coverage/coveralls — Coverage remained the same at 70.36%
Details
5491777

mdboom added the needs_review label Jul 16, 2016

Kojoley referenced this pull request Jul 16, 2016

Open

Migration to Py.test testing framework #6731

28 of 39 tasks complete
@tacaswell
Owner

tacaswell commented Jul 16, 2016

This makes sense but what motivated this change?

tacaswell added this to the 2.1 (next point release) milestone Jul 16, 2016

@Kojoley
Member

Kojoley commented Jul 16, 2016 • edited

pytest fails on test_axes.test_eventplot_problem_kwargs test and I have discovered that this issue actually persists in other places too, so after that I have fixed all the warnings.catch_warnings uses but have struck on test_figure.test_too_many_figures test that currently does not even work (it raises two warnings with range(22), but not one).
@tacaswell
Owner

tacaswell commented Jul 16, 2016

pep8 is fixed on master already.

Not bothering to wait for appveyor, it is super backed up today

@tacaswell tacaswell merged commit 6d339ed into matplotlib:master Jul 16, 2016
1 of 3 checks passed

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
coverage/coveralls Coverage remained the same at 70.36%
Details

tacaswell removed the needs_review label Jul 16, 2016

@QuLogic
Member

QuLogic commented Jul 16, 2016

Would any of these need backporting?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment