Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Allow creating annotation arrows w/ default props. #6799
Conversation
mdboom
added the
needs_review
label
Jul 19, 2016
tacaswell
added this to the
2.1 (next point release)
milestone
Jul 20, 2016
|
Although it is not a documented API change, I think this should get an api_changes entry noting that the code has been brought inline with the documentation. |
|
done |
tacaswell
merged commit 0fadaaf
into matplotlib:master
Jul 26, 2016
tacaswell
removed the
needs_review
label
Jul 26, 2016
anntzer
deleted the
anntzer:annotation-default-arrow branch
Jul 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anntzer commentedJul 19, 2016
annotate(..., arrowprops={})now uses an arrow with the default arrowproperties, rather than no arrow. Note that this matches the docstring
of
annotate, which indicates that "arrowprops, if not None, is adictionary of line properties (see matplotlib.lines.Line2D) for the
arrow that connects annotation to the point."
Comes down to checking for
Noneinstead of falsiness ofarrowprops.