Allow creating annotation arrows w/ default props. #6799

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
3 participants
Contributor

anntzer commented Jul 19, 2016

annotate(..., arrowprops={}) now uses an arrow with the default arrow
properties, rather than no arrow. Note that this matches the docstring
of annotate, which indicates that "arrowprops, if not None, is a
dictionary of line properties (see matplotlib.lines.Line2D) for the
arrow that connects annotation to the point."

Comes down to checking for None instead of falsiness of arrowprops.

mdboom added the needs_review label Jul 19, 2016

tacaswell added this to the 2.1 (next point release) milestone Jul 20, 2016

Owner

tacaswell commented Jul 20, 2016

👍 to merging this change.

Although it is not a documented API change, I think this should get an api_changes entry noting that the code has been brought inline with the documentation.

@anntzer anntzer Allow creating annotation arrows w/ default props.
`annotate(..., arrowprops={})` now uses an arrow with the default arrow
properties, rather than no arrow.  Note that this matches the docstring
of `annotate`, which indicates that "arrowprops, if not None, is a
dictionary of line properties (see matplotlib.lines.Line2D) for the
arrow that connects annotation to the point."

Comes down to checking for `None` instead of falsiness of `arrowprops`.
5dd8bcb
Contributor

anntzer commented Jul 20, 2016

done

@tacaswell tacaswell merged commit 0fadaaf into matplotlib:master Jul 26, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.002%) to 70.369%
Details

tacaswell removed the needs_review label Jul 26, 2016

anntzer deleted the anntzer:annotation-default-arrow branch Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment