/matplotlib

Deprecate `{get,set}_cursorprops`. #6807

Merged
merged 1 commit into from Jul 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@anntzer @tacaswell @mdboom
@anntzer
Contributor

anntzer commented Jul 21, 2016

Apparently unused and with no effect ever since they were added. See original
discussion in #6603.

mdboom added the needs_review label Jul 21, 2016

tacaswell added this to the 2.1 (next point release) milestone Jul 21, 2016

@tacaswell tacaswell and 1 other commented on an outdated diff Jul 21, 2016

View full outdated diff
lib/matplotlib/axes/_base.py
@@ -3666,6 +3664,7 @@ def format_deltas(key, dx, dy):
self.set_xlim(*result.intervalx)
self.set_ylim(*result.intervaly)
+ @cbook.deprecated("2.0")
@tacaswell

tacaswell Jul 21, 2016

Owner

can this target 2.1?

@anntzer

anntzer Jul 21, 2016

Contributor

done
@anntzer anntzer Deprecate `{get,set}_cursorprops`. 
Apparently unused and with no effect ever since they were added.

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.01%) to 70.359%
Details
fb58965
@tacaswell
Owner

tacaswell commented Jul 21, 2016

LGTM 👍

@tacaswell tacaswell merged commit 2a7f606 into matplotlib:master Jul 23, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 70.359%
Details

tacaswell removed the needs_review label Jul 23, 2016

anntzer deleted the anntzer:deprecate-cursorprops branch Jul 23, 2016

anntzer restored the anntzer:deprecate-cursorprops branch Jul 24, 2016

anntzer deleted the anntzer:deprecate-cursorprops branch Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment