/matplotlib

Don't forget to disconnect callbacks for dragging. #6808

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v2.0.0
4 participants
@anntzer @QuLogic @tacaswell @mdboom
@anntzer
Contributor

anntzer commented Jul 21, 2016 • edited

Copy-pasted from #6785 (comment):

There's at least another issue with the DraggableBase code: the mouse move callback (._c1) does not get disconnected when .disconnect() is called (I tried explicitly calling .disconnect() to work around the above-mentioned issue, but I then get a crash upon moving the mouse because on_motion becomes invalid).
@anntzer anntzer Don't forget to disconnect callbacks for dragging.

Some checks were not successful

1 failing and 2 successful checks
coverage/coveralls — Coverage decreased (-0.008%) to 70.361%
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
c6d9f97

mdboom added the needs_review label Jul 21, 2016

@tacaswell tacaswell merged commit 3cb79ed into matplotlib:master Jul 22, 2016
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.008%) to 70.361%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

tacaswell removed the needs_review label Jul 22, 2016

anntzer deleted the anntzer:dont-forget-to-disconnect-dragging-callbacks branch Jul 22, 2016

QuLogic added this to the 2.1 (next point release) milestone Jul 22, 2016

anntzer referenced this pull request Sep 2, 2016

Closed

Callbacks of draggable artists should check that they have not been removed #6785

@QuLogic
Member

QuLogic commented Sep 9, 2016

The original ticket is milestoned for 2.x, but this one isn't, or at least hasn't been backported. Maybe it should be?

@tacaswell tacaswell added a commit that referenced this pull request Sep 9, 2016

@tacaswell tacaswell Merge pull request #6808 from anntzer/dont-forget-to-disconnect-dragg… 
…ing-callbacks

FIX: Don't forget to disconnect callbacks for dragging.
 85f6bfc
@tacaswell
Owner

tacaswell commented Sep 9, 2016

backported to v2.x as 85f6bfc

@tacaswell tacaswell modified the milestone: 2.0 (style change major release), 2.1 (next point release), 2.0.1 (next bug fix release) Sep 9, 2016

@QuLogic QuLogic modified the milestone: 2.0.1 (next bug fix release), 2.0 (style change major release) Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment