Add xkcd font as one of the options #6811

Merged
merged 3 commits into from Jul 23, 2016

Conversation

Projects
None yet
5 participants
Contributor

peterfpeterson commented Jul 21, 2016

The official xkcd font https://github.com/ipython/xkcd-font
was missing from the list of what is looked for when the
user selects xkcd mode. Since it is the "official" font, it
has been added to the top of the list.

@peterfpeterson peterfpeterson Add xkcd font as one of the options
The official xkcd font https://github.com/ipython/xkcd-font
was missing from the list of what is looked for when the
user selects xkcd mode. Since it is the "official" font, it
has been added to the top of the list.
cb11f27

mdboom added the needs_review label Jul 21, 2016

Owner

tacaswell commented Jul 22, 2016

Does this correctly use the font if it is installed?

Contributor

peterfpeterson commented Jul 22, 2016

I installed the font in my ~/.fonts directory and it works beautifully. Should I modify this PR to include the changes @jenshnielsen suggested?

Owner

tacaswell commented Jul 22, 2016

Yes please.

@peterfpeterson peterfpeterson Add xkcd font as an option for font.fantasy
62178aa

@tacaswell tacaswell and 1 other commented on an outdated diff Jul 22, 2016

lib/matplotlib/rcsetup.py
@@ -1000,7 +1000,7 @@ def validate_animation_writer_path(p):
'Sand', 'Script MT', 'Felipa', 'cursive'],
validate_stringlist],
'font.fantasy': [['Comic Sans MS', 'Chicago', 'Charcoal', 'Impact'
- 'Western', 'Humor Sans', 'fantasy'],
+ 'Western', 'Humor Sans', 'fantasy, xkcd'],
@tacaswell

tacaswell Jul 22, 2016

Owner

This looks wrong, are there missing '' here?

@peterfpeterson

peterfpeterson Jul 22, 2016

Contributor

Hopefully build servers pick that one up.

@peterfpeterson peterfpeterson Fix quotation mistake
3af9530

@tacaswell tacaswell merged commit 64ad40b into matplotlib:master Jul 23, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 70.359%
Details

tacaswell removed the needs_review label Jul 23, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jul 23, 2016

@tacaswell tacaswell Merge pull request #6811 from peterfpeterson/xkcd_font
ENH: Add xkcd font as one of the options in xkcd style
8751f9b
Owner

tacaswell commented Jul 23, 2016

Backported to 2.x as 8751f9b

Thanks @peterfpeterson

Member

QuLogic commented Jul 23, 2016

Hmm, isn't fantasy a meta-name for fonts and should be last?

Owner

tacaswell commented Jul 23, 2016

it is very possible I screwed up here.

@QuLogic QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016

@QuLogic QuLogic Ensure meta font names are listed last.
cf. last comments on #6811.
cba07e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment