/matplotlib

Add mpl_toolkits to coveragerc. #6819

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
6 participants
@anntzer @Kojoley @jenshnielsen @mdboom @tacaswell @QuLogic
@anntzer
Contributor

anntzer commented Jul 24, 2016

Because, why not?
@anntzer anntzer Add mpl_toolkits to coveragerc.

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 70.351%
Details
7168c3e

mdboom added the needs_review label Jul 24, 2016

@tacaswell tacaswell merged commit b5b5a67 into matplotlib:master Jul 28, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 70.351%
Details

tacaswell removed the needs_review label Jul 28, 2016

QuLogic added this to the 2.1 (next point release) milestone Jul 28, 2016

@Kojoley
Member

Kojoley commented Jul 28, 2016 • edited

This does not work 😕
There is no files in coverage report from mpl_toolkits, file count is the same and coverage not changed. I think it is because of this line.
But even with such fix coverage report will be fooled, because nose does not report uncovered files (you can compare with this report from pytest-cov)
@jenshnielsen
Owner

jenshnielsen commented Jul 28, 2016

I think @Kojoley is right. I setup the original coverage but there are lots of issues with it and I have been postponing to change it until we have converted to pytest
@anntzer
Contributor

anntzer commented Jul 28, 2016

Ahh... OK, let's just wait for the conversion to pytest first then.

anntzer deleted the anntzer:add-mpl_toolkits-to-coverage branch Jul 28, 2016

Kojoley referenced this pull request Jul 28, 2016

Merged

Do not restrict coverage to `matplotlib` module only #6851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment