/matplotlib

Tick label rotation via `set_tick_params` #6829

Merged
merged 3 commits into from Jul 27, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@bcongdon @tacaswell @mdboom
@bcongdon
Contributor

bcongdon commented Jul 25, 2016

Addresses #6795.

Implemented @tacaswell's suggestion so that commands such as ax.xaxis.set_tick_params(which='both', rotation=90) are now possible.

Added related test and whats_new entry.

mdboom added the needs_review label Jul 25, 2016

@tacaswell tacaswell commented on an outdated diff Jul 25, 2016

View full outdated diff
lib/matplotlib/axis.py
@@ -73,6 +73,7 @@ def __init__(self, axes, loc, label,
pad=None,
labelsize=None,
labelcolor=None,
+ labelrotation=0,
@tacaswell

tacaswell Jul 25, 2016

Owner

Please put last so to preserve API

tacaswell added this to the 2.1 (next point release) milestone Jul 25, 2016

@tacaswell
Owner

tacaswell commented Jul 25, 2016

Can you add a test? I don't think this needs an image test, just verify that the rotation value ends up correctly on the tick labels.
@bcongdon bcongdon Added whats_new entry for axes tick rotation via set_tick_params

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 70.367%
Details
a755218
@bcongdon
Contributor

bcongdon commented Jul 25, 2016

I added this test to do assertion of label rotation. Is that sufficient?
@tacaswell
Owner

tacaswell commented Jul 25, 2016

👍 Looks great. Just waiting on CI.
@tacaswell
Owner

tacaswell commented Jul 26, 2016

Sorry, one last thing, can you also update the docstrings in set_params in axes/_base.py ?
@bcongdon bcongdon Added labelrotation to tick_params docstrings

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.03%) to 70.373%
Details
edbe0cc
@bcongdon
Contributor

bcongdon commented Jul 26, 2016

Yup, done.

@tacaswell tacaswell merged commit d308eec into matplotlib:master Jul 27, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 70.373%
Details

tacaswell removed the needs_review label Jul 27, 2016

tacaswell referenced this pull request Aug 2, 2016

Closed

suggestion: set_xticklabels and set_yticklabels default to current labels #6795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment