/matplotlib

Fixed broken `test_pickle.test_complete` test #6840

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Testing
Projects
None yet
Milestone
  2.1 (next point r...
5 participants
@Kojoley @jenshnielsen @tacaswell @mdboom @QuLogic
@Kojoley
Member

Kojoley commented Jul 26, 2016

Fixes #6839

mdboom added the needs_review label Jul 26, 2016

@jenshnielsen
Owner

jenshnielsen commented Jul 26, 2016

Looks right to me. The cleanup and image_comparison decorators should not be used together.

Kojoley referenced this pull request Jul 26, 2016

Closed

Test `test_pickle.test_complete` is broken #6839

@Kojoley Kojoley Fixed broken `test_pickle.test_complete` test

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.08%) to 70.447%
Details
46131d4

Kojoley referenced this pull request Jul 27, 2016

Open

Migration to Py.test testing framework #6731

28 of 39 tasks complete

@tacaswell tacaswell merged commit f1f8fed into matplotlib:master Jul 28, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 70.447%
Details

tacaswell removed the needs_review label Jul 28, 2016

@tacaswell
Owner

tacaswell commented Jul 28, 2016

This does not backport cleanly due to subtle changes in the stream plot.

attn @afvincent

@tacaswell tacaswell added a commit that referenced this pull request Jul 31, 2016

@tacaswell tacaswell Merge pull request #6840 from Kojoley/fix-test_pickle-test_complete 
TST: Fixed broken `test_pickle.test_complete` test
 aaeaffd
@tacaswell
Owner

tacaswell commented Jul 31, 2016

I screwed up and pushed this backport to upstream as aaeaffd I am going to give travis a chance to confirm that it fails and then revert it.

@tacaswell tacaswell added a commit that referenced this pull request Jul 31, 2016

@tacaswell tacaswell Revert "Merge pull request #6840 from Kojoley/fix-test_pickle-test_co… 
…mplete"

This reverts commit aaeaffd.
 c9c2bfe
@tacaswell
Owner

tacaswell commented Jul 31, 2016

Reverted the backport to un-break 2.x as c9c2bfe

Sorry folks 🐑

QuLogic added this to the 2.1 (next point release) milestone Aug 1, 2016

@story645 story645 added a commit to story645/matplotlib that referenced this pull request Aug 17, 2016

@tacaswell @story645 tacaswell + story645 Revert "Merge pull request #6840 from Kojoley/fix-test_pickle-test_co… 
…mplete"

This reverts commit aaeaffd.
 9c3cf1f

QuLogic added the Testing label Oct 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment