DOC: Fix `psd_demo_complex` similarly to `psd_demo3` #6843

Merged
merged 3 commits into from Jul 28, 2016

Conversation

Projects
None yet
4 participants
Contributor

afvincent commented Jul 26, 2016

Reports on psd_demo_complex some fixes similar to the ones done in #6841 on psd_demo3 (from which this example is derived):

  • OO code style
  • set a fixed y-range

NB: as the axes were not shared between the subplots in psd_demo3, I removed the sharing in this PR. It might be reintroduced if needed.

Besides, the 2nd commit halves the x-tick amount, because otherwise the x-tick labels overlap. Currently, the example looks like:
fix_psd_demo_complex
vs the current one in the devdocs gallery:
devdocs_psd_demo_complex

BTW, is it normal for the PNG in the devdocs gallery to be only 550x450 pixels?

afvincent added some commits Jul 26, 2016

@afvincent afvincent Switch to OO code style & ensure y-range 8dad861
@afvincent afvincent Reduce x-ticks amount (by 2)
063bccf

mdboom added the needs_review label Jul 26, 2016

@afvincent afvincent Use a RandomState instance with a fixed seed
f0d4080
Contributor

afvincent commented Jul 26, 2016

Now forcing the (pseudo-)random draws to be repeatable.

@tacaswell tacaswell merged commit e6efa8e into matplotlib:master Jul 28, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 70.347%
Details

tacaswell removed the needs_review label Jul 28, 2016

@tacaswell tacaswell added a commit that referenced this pull request Jul 28, 2016

@tacaswell tacaswell Merge pull request #6843 from afvincent/fix_psd_demo_complex
DOC: Fix `psd_demo_complex` similarly to `psd_demo3`
d1d7d7a
Owner

tacaswell commented Jul 28, 2016

backported to v2.x as d1d7d7a

afvincent deleted the afvincent:fix_psd_demo_complex branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment