/matplotlib

`test_tinypages`: pytest compatible module level setup #6848

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  2.1 (next point r...
3 participants
@Kojoley @tacaswell @mdboom
@Kojoley
Member

Kojoley commented Jul 27, 2016

Currently nose fails if there is no sphinx-build

mdboom added the needs_review label Jul 27, 2016

tacaswell added this to the 2.1 (next point release) milestone Jul 28, 2016

@tacaswell
Owner

tacaswell commented Jul 28, 2016

Why does moving the fail into the class level setup behave better than being in the module level?
@Kojoley Kojoley `test_tinypages`: pytest compatible module level setup

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.002%) to 70.447%
Details
54bb09b
@Kojoley
Member

Kojoley commented Jul 28, 2016

It is quite odd, but today it works for me as is.
Anyway setup should be renamed to setup_module to be compatible with pytest.

Kojoley changed the title from Check if `sphinx-build` available before executing the test to `test_tinypages`: pytest compatible module level setup Jul 28, 2016

@tacaswell tacaswell merged commit 31a5e57 into matplotlib:master Aug 2, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 70.447%
Details

tacaswell removed the needs_review label Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment