/matplotlib

Update ggplot URLs #6861

Merged
merged 2 commits into from Aug 2, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
  v1.5.3
5 participants
@andreas-h @tacaswell @jenshnielsen @mdboom @QuLogic
@andreas-h
Contributor

andreas-h commented Jul 30, 2016

see #6859. while at it, changed link to R to https
@andreas-h andreas-h Update ggplot URLs 
see #6859

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage remained the same at 70.445%
Details
43be21d

mdboom added the needs_review label Jul 30, 2016

@tacaswell tacaswell and 2 others commented on an outdated diff Jul 31, 2016

View full outdated diff
examples/style_sheets/plot_ggplot.py
@@ -6,8 +6,8 @@
.. [1] http://www.huyng.com/posts/sane-color-scheme-for-matplotlib/
-.. _ggplot: http://had.co.nz/ggplot/
-.. _R: http://www.r-project.org/
+.. _ggplot: https://github.com/yhat/ggplot
@tacaswell

tacaswell Jul 31, 2016

Owner

This is the python library built on top of mpl, not the R library.

@jenshnielsen

jenshnielsen Jul 31, 2016

Owner

I think this is the right url http://ggplot.yhathq.com/

@andreas-h

andreas-h Jul 31, 2016

Contributor

sorry, my bad. fixed to http://ggplot2.org/ I'm not sure about the 2, though. But it looks right.

tacaswell added this to the 2.0.1 (next bug fix release) milestone Jul 31, 2016

tacaswell added the Documentation label Jul 31, 2016

@andreas-h andreas-h Update plot_ggplot.py

All checks have passed

3 successful checks
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.003%) to 70.448%
Details
0c01f34

@tacaswell tacaswell merged commit 13b6f43 into matplotlib:master Aug 2, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 70.448%
Details

tacaswell removed the needs_review label Aug 2, 2016

@tacaswell tacaswell added a commit that referenced this pull request Aug 2, 2016

@tacaswell tacaswell Merge pull request #6861 from andreas-h/patch-2 
DOC: Update ggplot URLs
 b6192a6
@tacaswell
Owner

tacaswell commented Aug 2, 2016

backported to v1.5.2-doc as b6192a6
@tacaswell
Owner

tacaswell commented Aug 2, 2016

🎉

From github stalking it looks like this is your first contribution in ~4yrs.

Thank you and hopefully we will hear from you again in < 4 years.

@QuLogic QuLogic modified the milestone: 2.0 (style change major release), 2.0.1 (next bug fix release) Aug 2, 2016

@arafune arafune added a commit to arafune/matplotlib that referenced this pull request Aug 7, 2016

@arafune arafune Merge commit '70e7a6c4e9c5effbbb5ad9c261af2cca6d31a90c' 
* commit '70e7a6c4e9c5effbbb5ad9c261af2cca6d31a90c':
  Feedback from review
  Merge pull request #6832 from hoiqs/tex-unicode-demo
  Merge pull request #6881 from pdebuyl/master
  Merge pull request #6861 from andreas-h/patch-2
  Merge pull request #6878 from matthew-brett/use-venv-for-py3
  dtype names must be strings and not unicode in python2
  Make longshort python3 compatible
  Revert "Remove out of datelongshort example"
  interkeys should be called on the dict and not the keys
  np.dtype does not support unicode strings on python 2.7 so encode before creating
  Remove out of datelongshort example
  rc_traits example depends on traits so don't run it during docss build
  Multiprocess example depends on gtk so don't run it during docss build
  Don't try to run image_thumbnail example as part of docs build
  Run misc examples as part of docs build
  Merge pull request #6683 from afvincent/new_entry_mailmap_for_afvincent
  DOC: add DOI for 1.5.2

# Conflicts:
#	.mailmap
 3c193b0

This was referenced Aug 26, 2016

Closed
Closed

@QuLogic QuLogic modified the milestone: v1.5.x, 2.0 (style change major release) Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment